fix: ensure query timeout is respected at router#19402
Draft
jtuglu1 wants to merge 1 commit intoapache:masterfrom
Draft
fix: ensure query timeout is respected at router#19402jtuglu1 wants to merge 1 commit intoapache:masterfrom
jtuglu1 wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have seen queries fail to reach upstream brokers for a variety of reasons (lack of available broker connections, DNS issues, etc.). In these cases, the router does not fall-back to a sensible timeout (defaulting to the 15mins connection timeout). Since the router is part of Druid, we should be treating the maximum timeout as the min(query timeout, configured router<-->broker connection timeout) to avoid pathological cases where users expect a result in ≤ {query timeout} but end up receiving it 15mins later (or whatever
druid.router.http.readTimeoutis set to).Other databases separate timeouts into connection vs read timeouts, the former being a timeout on the time taken for the client to establish a connection to the server whereas the latter is a bound on the time taken to perform the actual query. This ensures Druid properly sets read timeout to be the minimum of
druid.router.http.readTimeoutand user-specified/cluster-configured default query timeout.Release note
Key changed/added classes in this PR
MyFooOurBarTheirBazThis PR has: