test: convert tests in druid-processing to junit5 pt. 8#19387
Open
clintropolis wants to merge 1 commit intoapache:masterfrom
Open
test: convert tests in druid-processing to junit5 pt. 8#19387clintropolis wants to merge 1 commit intoapache:masterfrom
clintropolis wants to merge 1 commit intoapache:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| final File toDir = temporaryFolder.newFolder(); | ||
| final File fromFile = File.createTempFile("from", null, temporaryFolder); | ||
| final File toDir = new File(temporaryFolder, "toDir"); | ||
| toDir.mkdir(); |
| { | ||
| File baseDir = folder.newFolder("base"); | ||
| File baseDir = new File(folder, "base"); | ||
| baseDir.mkdir(); |
| { | ||
| File baseDir = folder.newFolder("base"); | ||
| File baseDir = new File(folder, "base"); | ||
| baseDir.mkdir(); |
| { | ||
| File baseDir = folder.newFolder("base"); | ||
| File baseDir = new File(folder, "base"); | ||
| baseDir.mkdir(); |
| final SegmentFileChannel writer = smoosher.addWithChannel(StringUtils.format("%d", i), 4); | ||
| writer.write(ByteBuffer.wrap(Ints.toByteArray(i))); | ||
| File baseDir = new File(folder, "base"); | ||
| baseDir.mkdir(); |
|
|
||
| final File tmpFile2 = tempFolder.newFolder(); | ||
| final File tmpFile2 = new File(tempFolder, "dir2"); | ||
| tmpFile2.mkdir(); |
| { | ||
| final File tmpFile = tempFolder.newFolder(); | ||
| final File tmpFile = new File(tempFolder, "dir1"); | ||
| tmpFile.mkdir(); |
|
|
||
| final File tmpFile2 = tempFolder.newFolder(); | ||
| final File tmpFile2 = new File(tempFolder, "dir2"); | ||
| tmpFile2.mkdir(); |
| // value sizes increase until they span at least 3 pages of compressed buffers | ||
| final File tmpFile = tempFolder.newFolder(); | ||
| final File tmpFile = new File(tempFolder, "dir1"); | ||
| tmpFile.mkdir(); |
|
|
||
| final File tmpFile2 = tempFolder.newFolder(); | ||
| final File tmpFile2 = new File(tempFolder, "dir2"); | ||
| tmpFile2.mkdir(); |
Member
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
This is an automated review by Codex GPT-5
capistrant
approved these changes
Apr 30, 2026
Contributor
capistrant
left a comment
capistrant
left a comment
There was a problem hiding this comment.
all that chatter from the bots about not checking the result of mkdir seems ok since these are just tests. I guess it could make troubleshooting confusing if mkdir failing quietly makes a test fail in a hard to decipher way. but 🤷 I'm ok with no adjustment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
next batch
previous: