Console: Report workers active with any interesting activity.#19183
Open
gianm wants to merge 1 commit intoapache:masterfrom
Open
Console: Report workers active with any interesting activity.#19183gianm wants to merge 1 commit intoapache:masterfrom
gianm wants to merge 1 commit intoapache:masterfrom
Conversation
Currently workers are reported as active in the web console if they report nonzero rows for any channel. However, because segment input rows are typically reported when the segment is done processing, workers that just started can be active even when they have not yet reported rows. This patch adjusts the logic such that any nonzero rows, files, bytes, frames, or wall time is enough to consider a worker active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently workers are reported as active in the web console if they report nonzero rows for any channel. However, because segment input rows are typically reported when the segment is done processing, workers that just started can be active even when they have not yet reported rows.
This patch adjusts the logic such that any nonzero rows, files, bytes, frames, or wall time is enough to consider a worker active.