-
Notifications
You must be signed in to change notification settings - Fork 3.8k
gha should not ignore flaky failure #19134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cecemei
wants to merge
9
commits into
apache:master
Choose a base branch
from
cecemei:gha3.1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−0
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8e13fb8
Revert "fix native compaction oom issue (#19121)"
cecemei 58e5c69
schema
cecemei 287e6b7
Merge remote-tracking branch 'origin/master' into gha3
cecemei 3565c2a
revert
cecemei 6ae11b1
flaky-gha
cecemei dd938e3
flaky
cecemei 8a353fa
revert2
cecemei 1faf45a
trigger ci / empty commit
cecemei 6a106e0
test
cecemei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 Flaky errors are still ignored by CI
The normalization only rewrites flakyFailure elements, but Maven Surefire also emits flakyError for tests that error on an earlier attempt and pass on rerun. Those XML entries will remain flaky-only, so mikepenz/action-junit-report can still treat them as retries/flakes instead of failing the job. This leaves a common class of intermittent test failures hidden. The same handling should include flakyError -> error, and the summary/count should include both tag types.