-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](plan rewriter) remove rule EliminateNotNull #60189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yujun777
wants to merge
5
commits into
apache:master
Choose a base branch
from
yujun777:remove-eliminate-not-null
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31571 ms |
TPC-DS: Total hot run time: 176840 ms |
ClickBench: Total hot run time: 26.78 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31470 ms |
TPC-DS: Total hot run time: 175343 ms |
ClickBench: Total hot run time: 27.29 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Rule EliminateNotNull because it may causes mistaken deletion.
Step as follow:
for expression E1
E2 = E1 and a is not nullE3 = a is not nulla is not null, and gotE4=TRUE.then it will have E1 => TRUE, this have bug. For rule InferNotNull, we know that E1 will evaluate to NULL/FALSE when a is null, so E1 cannot always evaluate to true.
This PR also remove field isGeneratedIsNotNull for NOT.
related PR: #16411
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)