Skip to content

branch-4.0: [fix](load_stream) Fix use-after-free in TabletStream async lambdas #60148 #60177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jan 24, 2026
Merged

branch-4.0: [fix](load_stream) Fix use-after-free in TabletStream async lambdas #60148 #60177

yiguolei merged 1 commit into from
Jan 24, 2026

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 23, 2026

Cherry-picked from #60148

@liaoxin01
[fix](load_stream) Fix use-after-free in TabletStream async lambdas (#…
fd50f53 
…60148)

The async lambdas in TabletStream captured raw 'this' pointer, which
could become dangling when the TabletStream object is destroyed before
the async task completes (e.g., when thrift connection is broken).

Fix by using shared_from_this() to capture shared_ptr instead of raw
pointer, ensuring the object stays alive until all async tasks complete.
@github-actions github-actions bot requested a review from yiguolei as a code owner January 23, 2026 08:05
@Thearas
Copy link
Contributor

Thearas commented Jan 23, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 23, 2026
@Thearas
Copy link
Contributor

Thearas commented Jan 23, 2026

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 23, 2026
@github-actions
Copy link
Contributor Author

github-actions bot commented Jan 23, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented Jan 23, 2026

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 23, 2026

BE UT Coverage Report

Increment line coverage 66.67% (12/18) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.73% (18902/35848)
Line Coverage 35.84% (175512/489670)
Region Coverage 32.47% (135735/418060)
Branch Coverage 33.34% (58862/176554)

@yiguolei
Copy link
Contributor

yiguolei commented Jan 24, 2026

skip buildall

@yiguolei yiguolei merged commit c18ef17 into branch-4.0 Jan 24, 2026
28 of 30 checks passed
@github-actions github-actions bot deleted the auto-pick-60148-branch-4.0 branch January 24, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @hello-stephen @yiguolei @dataroaring @liaoxin01