Skip to content

branch-4.0: [fix](distinct)fix distinct info is lost when union's children are distinct #60085 #60176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jan 24, 2026
Merged

branch-4.0: [fix](distinct)fix distinct info is lost when union's children are distinct #60085 #60176

yiguolei merged 1 commit into from
Jan 24, 2026
+52 −8

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 23, 2026

Cherry-picked from #60085

@starocean999
[fix](distinct)fix distinct info is lost when union's children are di…
8342d1c 
…stinct (#60085)

In bindSetOperation, we merge LogicalSetOperation's children if they are
ProjectMergeable, but the LogicalProject node may be distinct and hasn't
been transfer to LogicalAggregate by ProjectWithDistinctToAggregate. So
we can't merge projects so early, and should leave the merge operation
in rewritten phase

Related PR: #43546
@github-actions github-actions bot requested a review from yiguolei as a code owner January 23, 2026 07:44
@Thearas
Copy link
Contributor

Thearas commented Jan 23, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 23, 2026
@Thearas
Copy link
Contributor

Thearas commented Jan 23, 2026

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 23, 2026

FE UT Coverage Report

Increment line coverage 91.30% (21/23) 🎉
Increment coverage report
Complete coverage report

@yiguolei
Copy link
Contributor

yiguolei commented Jan 24, 2026

skip buildall

@github-actions
Copy link
Contributor Author

github-actions bot commented Jan 24, 2026

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 24, 2026
@github-actions
Copy link
Contributor Author

github-actions bot commented Jan 24, 2026

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit bb383f1 into branch-4.0 Jan 24, 2026
27 of 30 checks passed
@github-actions github-actions bot deleted the auto-pick-60085-branch-4.0 branch January 24, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @hello-stephen @yiguolei @dataroaring @starocean999