-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feature](hive_write) add hive_staging_dir catalog properties and change default value under the writing target table. #60018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 31946 ms |
TPC-DS: Total hot run time: 173189 ms |
ClickBench: Total hot run time: 26.68 s |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
…nge default value under the writing target table.
8a3584f to
094e581
Compare
|
run buildall |
TPC-H: Total hot run time: 31635 ms |
TPC-DS: Total hot run time: 173731 ms |
ClickBench: Total hot run time: 26.89 s |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
| } | ||
| } | ||
|
|
||
| private static boolean isSubDirectory(String parent, String child) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add unit test for these static methods.
This check is very important, we need to cover every corner case, otherwise, we may delete data file accidentally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
| String user = ConnectContext.get().getCurrentUserIdentity().getUser(); | ||
| return LocationPath.getTempWritePath(location, "/tmp/.doris_staging/" + user); | ||
| String defaultStagingBaseDir = ".doris_staging"; | ||
| String stagingBaseDir = targetTable.getCatalog().getCatalogProperty() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can user specify this stage dir arbitrarily? Is it safe?
What if user specify dir like /etc or /?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should only support /tmp/.staging or relative dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other systems also use this facility.
|
run buildall |
3843b9f to
ab8c962
Compare
|
run buildall |
TPC-H: Total hot run time: 31196 ms |
TPC-DS: Total hot run time: 173374 ms |
ClickBench: Total hot run time: 27.14 s |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
What problem does this PR solve?
Problem Summary:
Release note
[feature] (hive_write) add hive_staging_dir catalog properties and change default value under the writing target table.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)