-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](rpc) Use resolved IP address for rpc connections instead of hostname to avoid DNS resolution failures #59904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
f4b16eb to
02f9524
Compare
|
run buildall |
TPC-H: Total hot run time: 31856 ms |
TPC-DS: Total hot run time: 174416 ms |
ClickBench: Total hot run time: 26.85 s |
FE UT Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
aea88ca to
f056591
Compare
|
run buildall |
TPC-H: Total hot run time: 31399 ms |
TPC-DS: Total hot run time: 174380 ms |
ClickBench: Total hot run time: 26.47 s |
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
…tname to avoid DNS resolution failures #59904
|
run buildall |
TPC-H: Total hot run time: 31541 ms |
TPC-DS: Total hot run time: 173319 ms |
ClickBench: Total hot run time: 26.63 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
What problem does this PR solve?
Solution:
parameter and use it instead of hostname when creating gRPC channel
compatible)
client constructor
cache returns empty string in FQDN mode
clients
where CachedClient contains both client_key and resolved_ip
to original hostport (with hostname)
are detected
consistency)
The existing IP change detection mechanism continues to work:
automatically
Testing:
Added comprehensive unit tests (21 test cases):
client management
vs hostname
Impact:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)