[Improvement-18249][DAO] Route TaskInstanceMapper access through TaskInstanceDao#18252
Open
ruanwenjun wants to merge 1 commit into
Open
[Improvement-18249][DAO] Route TaskInstanceMapper access through TaskInstanceDao#18252ruanwenjun wants to merge 1 commit into
ruanwenjun wants to merge 1 commit into
Conversation
…InstanceDao Tracking issue: apache#18249 Expose the methods the api layer needs on TaskInstanceDao (countTaskInstanceStateByProjectCodes, queryByWorkflowInstanceIdsAndTaskCodes, queryTaskInstanceListPaging, queryStreamTaskInstanceListPaging) and replace every direct TaskInstanceMapper reference in dolphinscheduler-api with the Dao, so Mapper usage stays inside dolphinscheduler-dao.repository as documented in dolphinscheduler-dao/CLAUDE.md. Notes: - selectById was replaced with the IDao#queryById equivalent. The Mapper's queryByInstanceIdAndCode is exposed on the Dao as the more descriptive queryByWorkflowInstanceIdAndTaskCode (already present); api callers were updated to the new name. - The Mapper's findValidTaskListByWorkflowInstanceId(id, Flag) is collapsed on the Dao to queryValidTaskListByWorkflowInstanceId(id), which already hard-codes Flag.YES. All current api callers passed Flag.YES so they drop the argument. - BaseDao#updateById returns boolean where the Mapper returned int; the affected call site in TaskInstanceServiceImpl#forceTaskSuccess (int changedNum = ...; if (changedNum <= 0) {...}) was refactored to boolean changed = ...; if (!changed) {...}. No production behavior changes; the Mapper interface itself is untouched.
ruanwenjun
added
backend
improvement
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES, ops 4.7
Purpose of the pull request
Tracking issue: #18249
Expose the methods the api layer needs on TaskInstanceDao (countTaskInstanceStateByProjectCodes, queryByWorkflowInstanceIdsAndTaskCodes, queryTaskInstanceListPaging, queryStreamTaskInstanceListPaging) and replace every direct TaskInstanceMapper reference in dolphinscheduler-api with the Dao, so Mapper usage stays inside dolphinscheduler-dao.repository as documented in dolphinscheduler-dao/CLAUDE.md.
Notes:
No production behavior changes; the Mapper interface itself is untouched.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md