Skip to content

Conversation

@XpengCen
Copy link
Contributor

Purpose of the pull request

This pull request close #17896

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 21, 2026

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Jan 22, 2026
@SbloodyS SbloodyS added this to the 3.4.1 milestone Jan 22, 2026
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XpengCen
Copy link
Contributor Author

Hey @SbloodyS @ruanwenjun @zhongjiajie ,the docs/ dead-link check failed because some links related to Seatunnel in the task description are broken. Should I fix them directly in this PR?

@SbloodyS
Copy link
Member

Hey @SbloodyS @ruanwenjun @zhongjiajie ,the docs/ dead-link check failed because some links related to Seatunnel in the task description are broken. Should I fix them directly in this PR?

You don't need to fix it.

@SbloodyS SbloodyS merged commit cea7c7e into apache:dev Jan 22, 2026
32 of 33 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 22, 2026

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

document improvement make more easy to user or prompt friendly ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc][Master] Fix incorrect default value for Quartz JobStore class

4 participants