Add Go cross-serde tests for CPC sketch #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakyzoidberg
approved these changes
May 12, 2025
Contributor
|
All of these CI tests are failing due to a missing file: java/serialization_test_data/go_generated_files/cpc_n0_go.sk |
Member
|
I'll check with him tomorrow - looks like we need to adapt the pom.xml to add a check-go-files profile (and exclude the test from the other profiles) |
Contributor
|
That makes sense. I hate to see his work go to waste!
From my cell phone.
…On Mon, Jul 7, 2025 at 3:48 PM Pierre Lacave ***@***.***> wrote:
*freakyzoidberg* left a comment (apache/datasketches-java#666)
<#666 (comment)>
I'll check with him tomorrow - looks like we need to adapt the pom.xml to
check-go-files in it's own profile (and exclude it from other profiles)
—
Reply to this email directly, view it on GitHub
<#666 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADCXRQV5Q2FKUN6BIDS5GIL3HL2K3AVCNFSM6AAAAAB45KJ3T2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANBWG4YTQNZXGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cross language deserialization tests for serialized sketches produced by datasketches-go