Skip to content

Improve bit packing #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexanderSaydakov merged 2 commits into from
Jan 10, 2025
Merged

Improve bit packing #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ececa07
better error messages
AlexanderSaydakov Jan 10, 2025
9639606
more rounds of pseudo-random data
AlexanderSaydakov Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions theta/include/bit_packing.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6201,7 +6201,7 @@ static inline void pack_bits_block8(const uint64_t* values, uint8_t* ptr, uint8_
case 61: pack_bits_61(values, ptr); break;
case 62: pack_bits_62(values, ptr); break;
case 63: pack_bits_63(values, ptr); break;
default: throw std::logic_error("wrong number of bits " + std::to_string(bits));
default: throw std::logic_error("wrong number of bits in pack_bits_block8: " + std::to_string(bits));
}
}

Expand Down Expand Up @@ -6270,7 +6270,7 @@ static inline void unpack_bits_block8(uint64_t* values, const uint8_t* ptr, uint
case 61: unpack_bits_61(values, ptr); break;
case 62: unpack_bits_62(values, ptr); break;
case 63: unpack_bits_63(values, ptr); break;
default: throw std::logic_error("wrong number of bits " + std::to_string(bits));
default: throw std::logic_error("wrong number of bits in unpack_bits_block8: " + std::to_string(bits));
}
}

Expand Down
4 changes: 2 additions & 2 deletions theta/test/bit_packing_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ static const uint64_t IGOLDEN64 = 0x9e3779b97f4a7c13ULL;

TEST_CASE("pack unpack bits") {
uint64_t value = 0xaa55aa55aa55aa55ULL; // arbitrary starting value
for (int m = 0; m < 100; ++m) {
for (int m = 0; m < 10000; ++m) {
for (uint8_t bits = 1; bits <= 63; ++bits) {
int n = 8;
const uint64_t mask = (1ULL << bits) - 1;
Expand Down Expand Up @@ -61,7 +61,7 @@ TEST_CASE("pack unpack bits") {

TEST_CASE("pack unpack blocks") {
uint64_t value = 0xaa55aa55aa55aa55ULL; // arbitrary starting value
for (int n = 0; n < 100; ++n) {
for (int n = 0; n < 10000; ++n) {
for (uint8_t bits = 1; bits <= 63; ++bits) {
const uint64_t mask = (1ULL << bits) - 1;
std::vector<uint64_t> input(8, 0);
Expand Down
Loading