perf: add in-place fast path for ScalarValue::add#20959
Open
kumarUjjawal wants to merge 2 commits intoapache:mainfrom
Open
perf: add in-place fast path for ScalarValue::add#20959kumarUjjawal wants to merge 2 commits intoapache:mainfrom
kumarUjjawal wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Issue #20933 called out that
ScalarValue::addwas doing unnecessary work in hot paths such as statistics merging.The original suggestion was to mutate the lhs accumulator rather than alwaysbuilding a new scalar. This patch follows that direction and keeps the optimization in
ScalarValueitself, which is a better long-term fit than duplicating specialized addition logic only in the stats code.What changes are included in this PR?
This change adds an in-place fast path for
ScalarValue::add/add_checkedfor same-type numeric and decimal values.The patch also updates statistics merging to reuse the existing
sum_valueaccumulator instead of creating a newScalarValuefor each addition.Are these changes tested?
Yes
Are there any user-facing changes?