feat: Implement datafusion-spark sequence function#20955
Open
erenavsarogullari wants to merge 1 commit intoapache:mainfrom
Open
feat: Implement datafusion-spark sequence function#20955erenavsarogullari wants to merge 1 commit intoapache:mainfrom
datafusion-spark sequence function#20955erenavsarogullari wants to merge 1 commit intoapache:mainfrom
Conversation
708a434 to
744dcc7
Compare
744dcc7 to
be43998
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-sparksequencefunction #20540.Rationale for this change
Ref EPIC: #15914
datafusion-sparksubmodule needssequence functionsupport by following diverse cases and enabling sequence.slt:Please find sample use cases:
Case1: Natural order:
Case2: Reverse order:
Case3: Natural order with internal:
Case4: Reverse order with internal:
Case5: Date / Timestamp without interval
Case6: Date / Timestamp with interval
Case 7 & 8: Date / Timestamp with interval and reverse order
Case 9: NULL inputs
Case 10: Negative Cases
Ref: https://docs.databricks.com/aws/en/sql/language-manual/functions/sequence
Note: In addition to above use cases, planning to add more cases by follow-up PRs in terms of further testing current Spark sequence behaviour so this is initial effort to help reviewers and the integration.
What changes are included in this PR?
This PR introduces new
datafusion-sparksequencefunction support.Are these changes tested?
Yes, added new test cases under
sequence.sltAre there any user-facing changes?
Yes, new
datafusion-sparksequencefunction is being added.