Open
Conversation
5a7328a to
a5ccd80
Compare
a5ccd80 to
01598d9
Compare
alamb
reviewed
Mar 13, 2026
| spill_stream, | ||
| 1, // Each receiver handles one input partition | ||
| BaselineMetrics::new(&metrics, partition), | ||
| BaselineMetrics::new(&intermediate_metrics, partition), |
Contributor
There was a problem hiding this comment.
if we are just going to ignore the metrics, should we just remove them from PerPartitionStream ?
It seems like using a local copy of ExecutionPlanMetrics means they metrics in the PerPartitionStream are no longer accessable. So we can probably just remove the metrics to make it clearer they aren't used
Contributor
Author
There was a problem hiding this comment.
Yeah good question, we still use PerPartitionStream here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Found this when working on #20875
Rationale for this change
Metric reporting was previously incorrect for
RepartitionExecif preserve order was set to true.What changes are included in this PR?
Create new metrics before creating
PerPartitionStreamAre these changes tested?
Yes and confirmed that this fails on main:
Are there any user-facing changes?