fix: change token consumption to pick to test on EOF in parser #19927
+44
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
approved these changes
Jan 22, 2026
If we use `next_token(...)` then in the case of multi-statement query it consumes a semicolon token which leads to the parse error on the correct queries like: ```sql CREATE EXTERNAL TABLE t1 ...; CREATE EXTERNAL TABLE t2 ...; ```
askalt
force-pushed
the
askalt/use-pick-in-parser
branch
from
ef2c3ae to
e2a3470
Compare
Jefffrey
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In our project we support multi-statement SQL with DF statements.
If we use
next_token(...)then in the case of multi-statement query it consumes a semicolon token which leads to the parse error on the correct queries like:This patch fixes this behavior switching
next_token(...)topeek_token(...)to test on EOF.Are these changes tested?
There is a unit test covering multi-statement SQL.