fix: derive nullability for spark bit_get
#19220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumarUjjawal
changed the title
bit_get
rluvaton
reviewed
Dec 9, 2025
| } | ||
|
|
||
| fn return_field_from_args(&self, args: ReturnFieldArgs) -> Result<FieldRef> { | ||
| // Spark marks bit_get as null-intolerant: result is nullable only if an input can be null |
Member
There was a problem hiding this comment.
It is not that it is because of null-intolerant but because nullable is derived from the children
Contributor
Author
There was a problem hiding this comment.
Would Spark derives nullability for BinaryExpression from its children be more appropriate comment?
Member
|
I verified that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
bit_getneed to have custom nullability #19148.Rationale for this change
As stated in the original issue the UDF uses the default is_nullable which is always true which is not the case.
What changes are included in this PR?
bit_getnow reports schema usingreturn_field_from_argsAre these changes tested?
Are there any user-facing changes?