-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore: remove pyarrow feature
#18528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c8967f5 to
077fb8c
Compare
milenkovicm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, would it be appropriate to include this breaking change in the “Upgrade Guide”? You already mentioned in the issue description that “if you need it, use DataFusion Python”.
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @timsaucer -- I agree with @milenkovicm that a note in the upgrade guide would be best
I also suggest we wait until we have made the branch-51 for the 51 release to merge this one so it gets more "bake time" on main
|
Moved to draft until release 51 branch is created. |
|
FYI branch-51 is created |
|
|
||
| ## DataFusion `52.0.0` | ||
|
|
||
| TODO(tsaucer) Add link to issue for 52 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is the ticket: #18566
|
I added in a minor fix to |
I think @comphead did a similar change in |
|
i guess this can be merged once conflicts are resolved |
|
I merged up from main and resolved some conflicts |
Which issue does this PR close?
Rationale for this change
Our python downstream library no longer uses the feature
pyarrowin this repository #1000. As such, this feature is no longer needed.What changes are included in this PR?
Code removal
Are these changes tested?
Tested against datafusion-python repo. No build issues.
Are there any user-facing changes?
If any user needs this code, they will need to migrate to the
datafusion-pythonrepository as their dependency.