Skip to content

Conversation

@timsaucer
Copy link
Member

@timsaucer timsaucer commented Nov 7, 2025

Which issue does this PR close?

Rationale for this change

Our python downstream library no longer uses the feature pyarrow in this repository #1000. As such, this feature is no longer needed.

What changes are included in this PR?

Code removal

Are these changes tested?

Tested against datafusion-python repo. No build issues.

Are there any user-facing changes?

If any user needs this code, they will need to migrate to the datafusion-python repository as their dependency.

@github-actions github-actions bot added documentation Improvements or additions to documentation development-process Related to development process of DataFusion core Core DataFusion crate common Related to common crate labels Nov 7, 2025
@timsaucer timsaucer force-pushed the chore/remove-pyarrow branch from c8967f5 to 077fb8c Compare November 7, 2025 12:14
@timsaucer timsaucer marked this pull request as ready for review November 7, 2025 12:43
Copy link
Contributor

@milenkovicm milenkovicm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, would it be appropriate to include this breaking change in the “Upgrade Guide”? You already mentioned in the issue description that “if you need it, use DataFusion Python”.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timsaucer -- I agree with @milenkovicm that a note in the upgrade guide would be best

I also suggest we wait until we have made the branch-51 for the 51 release to merge this one so it gets more "bake time" on main

@timsaucer timsaucer marked this pull request as draft November 8, 2025 14:42
@timsaucer
Copy link
Member Author

Moved to draft until release 51 branch is created.

@alamb
Copy link
Contributor

alamb commented Nov 10, 2025

FYI branch-51 is created


## DataFusion `52.0.0`

TODO(tsaucer) Add link to issue for 52 release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is the ticket: #18566

@timsaucer timsaucer marked this pull request as ready for review November 10, 2025 17:15
@timsaucer
Copy link
Member Author

I added in a minor fix to cargo machete introduced on main recently.

@github-actions github-actions bot added the catalog Related to the catalog crate label Nov 10, 2025
@alamb
Copy link
Contributor

alamb commented Nov 10, 2025

I added in a minor fix to cargo machete introduced on main recently.

I think @comphead did a similar change in

@milenkovicm
Copy link
Contributor

i guess this can be merged once conflicts are resolved

@github-actions github-actions bot removed the catalog Related to the catalog crate label Nov 23, 2025
@alamb alamb changed the title chore: remove pyarrow chore: remove pyarrow feature Nov 23, 2025
@alamb alamb added the api change Changes the API exposed to users of the crate label Nov 23, 2025
@alamb
Copy link
Contributor

alamb commented Nov 23, 2025

I merged up from main and resolved some conflicts

@timsaucer timsaucer added this pull request to the merge queue Nov 23, 2025
Merged via the queue into apache:main with commit fc77be9 Nov 23, 2025
31 checks passed
@timsaucer timsaucer deleted the chore/remove-pyarrow branch November 24, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change Changes the API exposed to users of the crate common Related to common crate core Core DataFusion crate development-process Related to development process of DataFusion documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Should we remove pyarrow feature from datafusion core

3 participants