fix: fallback NullType LocalTableScanExec to Spark#4458
Closed
pchintar wants to merge 1 commit into
Closed
Conversation
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4457 .
Rationale for this change
Queries containing
NullTypecolumns could fail whenspark.comet.exec.localTableScan.enabled=true.While plain
NullTypeprojections may execute successfully, aggregate queries can still reach native Arrow conversion paths throughCometLocalTableScanExecand fail with anUnsupportedOperationException.For example:
crashes during Arrow schema conversion in
CometLocalTableScanExec.What changes are included in this PR?
This PR adds an explicit support-level check for
NullTypecolumns inCometLocalTableScanExec.When a
LocalTableScanExeccontainsNullType, Comet now marks the operator as unsupported and falls back to Spark execution instead of attempting native Arrow conversion.This PR intentionally uses fallback behavior instead of adding full native
NullTypesupport becauseNullTypeis currently unsupported across downstream native aggregate and shuffle paths as well. Simply allowing Arrow schema conversion would move the failure deeper into execution rather than resolving the incompatibility consistently.A regression test has also been added for aggregate queries over
NullTypelocal table scans.How are these changes tested?
Added a regression test in
CometExecSuitecovering:with:
Before the fix, the query failed with:
After the fix, the query cleanly falls back to Spark execution and returns the expected result.
Test command used:
mvn -pl spark -DwildcardSuites=org.apache.comet.exec.CometExecSuite test