-
Notifications
You must be signed in to change notification settings - Fork 299
fix: Iceberg reflection for current() on TableOperations hierarchy #3895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
karuppayya
wants to merge
2
commits into
apache:main
Choose a base branch
from
karuppayya:fix-mehthod-hierarchy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+84
−8
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
spark/src/test/scala/org/apache/comet/iceberg/IcebergReflectionSuite.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.comet.iceberg | ||
|
|
||
| import java.util.Collections | ||
|
|
||
| import org.scalatest.funsuite.AnyFunSuite | ||
|
|
||
| import org.apache.iceberg.BaseMetastoreTableOperations | ||
| import org.apache.iceberg.BaseTable | ||
| import org.apache.iceberg.Schema | ||
| import org.apache.iceberg.TableMetadata | ||
| import org.apache.iceberg.io.FileIO | ||
| import org.apache.iceberg.types.Types | ||
|
|
||
| class IcebergReflectionSuite extends AnyFunSuite { | ||
|
|
||
| /** Mimics HiveTableOperations/GlueTableOperations which inherit current(). */ | ||
| class StubTableOperations extends BaseMetastoreTableOperations { | ||
| override protected def tableName(): String = "test" | ||
| override def refresh(): TableMetadata = null | ||
| override def io(): FileIO = null | ||
| } | ||
|
|
||
| test("getTableMetadata succeeds when operations class inherits current()") { | ||
| val ops = new StubTableOperations() | ||
| val schema = new Schema(Types.NestedField.required(1, "id", Types.IntegerType.get())) | ||
| val expectedMetadata = TableMetadata.newTableMetadata( | ||
| schema, | ||
| org.apache.iceberg.PartitionSpec.unpartitioned(), | ||
| "file:///tmp/test-table", | ||
| Collections.emptyMap[String, String]()) | ||
| val metadataField = classOf[BaseMetastoreTableOperations] | ||
| .getDeclaredField("currentMetadata") | ||
| metadataField.setAccessible(true) | ||
| metadataField.set(ops, expectedMetadata) | ||
| // current() checks shouldRefresh (default true) and calls refresh() instead of | ||
| // returning currentMetadata. Set to false so current() returns our stubbed metadata. | ||
| val refreshField = classOf[BaseMetastoreTableOperations] | ||
| .getDeclaredField("shouldRefresh") | ||
| refreshField.setAccessible(true) | ||
| refreshField.set(ops, false) | ||
|
|
||
| val table = new BaseTable(ops, "test-table") | ||
| val metadata = IcebergReflection.getTableMetadata(table) | ||
| assert(metadata.isDefined) | ||
| assert(metadata.get.isInstanceOf[TableMetadata]) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is current the only method affected?
operations(a few lines above this) is callinggetDeclaredMethodalso.Also, are there other catalog implementations that could have similar issues but for other methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could always call replace all occurences of
getDeclaredMethodwithfindMethodInHierarchyEspecially, those that assume the superclass's depth seems fragile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbutrovich wdyt? Is there a potential performance impact here if we replace
getDeclaredMethodwithfindMethodInHierarchy?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I tried that at some point but it's been at least 6 months, open to trying again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking this over, I feel we can defer changing everything over to use
findMethodInHierarchyuntil we hit an issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sgtm