Skip to content

feat: support shiftrightunsigned expression #3590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
n0r0shi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support shiftrightunsigned expression #3590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions native/core/src/execution/jni_api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ use datafusion::{
};
use datafusion_comet_proto::spark_operator::Operator;
use datafusion_spark::function::bitwise::bit_get::SparkBitGet;
use datafusion_spark::function::bitwise::bit_shift::SparkShiftRightUnsigned;
use datafusion_spark::function::bitwise::bitwise_not::SparkBitwiseNot;
use datafusion_spark::function::datetime::date_add::SparkDateAdd;
use datafusion_spark::function::datetime::date_sub::SparkDateSub;
Expand Down Expand Up @@ -400,6 +401,7 @@ fn register_datafusion_spark_function(session_ctx: &SessionContext) {
session_ctx.register_udf(ScalarUDF::new_from_impl(SparkWidthBucket::default()));
session_ctx.register_udf(ScalarUDF::new_from_impl(MapFromEntries::default()));
session_ctx.register_udf(ScalarUDF::new_from_impl(SparkCrc32::default()));
session_ctx.register_udf(ScalarUDF::new_from_impl(SparkShiftRightUnsigned::default()));
}

/// Prepares arrow arrays for output.
Expand Down
3 changes: 2 additions & 1 deletion spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,8 @@ object QueryPlanSerde extends Logging with CometExprShim {
classOf[BitwiseNot] -> CometBitwiseNot,
classOf[BitwiseXor] -> CometBitwiseXor,
classOf[ShiftLeft] -> CometShiftLeft,
classOf[ShiftRight] -> CometShiftRight)
classOf[ShiftRight] -> CometShiftRight,
classOf[ShiftRightUnsigned] -> CometScalarFunction("shiftrightunsigned"))

private val temporalExpressions: Map[Class[_ <: Expression], CometExpressionSerde[_]] = Map(
classOf[DateAdd] -> CometDateAdd,
Expand Down
8 changes: 8 additions & 0 deletions spark/src/test/scala/org/apache/comet/CometBitwiseExpressionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,4 +198,12 @@ class CometBitwiseExpressionSuite extends CometTestBase with AdaptiveSparkPlanHe
}
}
}

test("shiftrightunsigned") {
withParquetTable(Seq((42, 2), (-1, 1), (255, 4), (0, 3), (Int.MinValue, 1)), "tbl") {
checkSparkAnswerAndOperator("SELECT shiftrightunsigned(_1, _2) FROM tbl")
checkSparkAnswerAndOperator("SELECT shiftrightunsigned(-1, 1) FROM tbl")
checkSparkAnswerAndOperator("SELECT shiftrightunsigned(NULL, 1) FROM tbl")
}
}
}