chore: Add consistency checks and result hashing to TPC benchmarks#3582
Merged
andygrove merged 10 commits intoapache:mainfrom Feb 24, 2026
Merged
chore: Add consistency checks and result hashing to TPC benchmarks#3582andygrove merged 10 commits intoapache:mainfrom
andygrove merged 10 commits intoapache:mainfrom
Conversation
andygrove
changed the title
andygrove
force-pushed
the
tpc-benchmark-consistency-checks
branch
from
d869058 to
f1783e5
Compare
Change `+ N days` to `+ interval N days` in 15 TPC-DS queries (q5, q12, q16, q20, q21, q32, q37, q40, q77, q80, q82, q92, q94, q95, q98) so they parse correctly in Spark SQL. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mbutrovich
approved these changes
Feb 24, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks @andygrove!
Rename comet.toml to comet-hashjoin.toml (keeps replaceSortMergeJoin=true) and create a new comet.toml without it, since replacing SMJ with hash join causes OOM on TPC-DS workloads. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Same approach as comet: comet-iceberg no longer replaces SMJ, and comet-iceberg-hashjoin is available for when hash join is desired. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The spark.eventLog.dir was hardcoded to /results/spark-events, a Docker-only path. Make it configurable via SPARK_EVENT_LOG_DIR env var, defaulting to /tmp/spark-events so local runs work out of the box. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…in TPC-DS q30 The customer table column is c_last_review_date, not c_last_review_date_sk. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ew_date in TPC-DS q30" This reverts commit c4a1af2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tpcbench.pyto detect correctness differences between benchmark runsgenerate-comparison.pyto support both old (list) and new (dict) result formatsExample result file format: