feat: zero-copy columnar conversion for ArrowColumnVector-backed batches#3520
Open
tokoko wants to merge 5 commits intoapache:mainfrom
Open
feat: zero-copy columnar conversion for ArrowColumnVector-backed batches#3520tokoko wants to merge 5 commits intoapache:mainfrom
tokoko wants to merge 5 commits intoapache:mainfrom
Conversation
Contributor
Author
|
This turned out to be a bit complicated. arrow classes in common module are shaded, while objects coming from spark aren't, so we can't just pass underlying ValueVectors through. PR uses c data interface split across common and spark modules. spark batches are exported to plain pointers on spark module side (which isn't shading arrow) and imported into CometVector batches in common. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3518
What changes are included in this PR?
tryZeroCopyConvertmethod inCometArrowConverterswhich receivesColumarBatchof any type and returnsColumnarBatchofCometVectorobjects if the input is composed ofArrowColumnVectorobjects, returns None otherwise.CometSparkToColumnarExecalways triestryZeroCopyConvertfirst and falls back to current flow if zero-copy conversion is impossible.How are these changes tested?
ColumnarBatchobjects as there's no out-of-box data source in spark that producesColumnarBatchofArrowColumnVectorobjects.