Skip to content

Conversation

@kumo01GitHub
Copy link
Contributor

@kumo01GitHub kumo01GitHub commented Apr 24, 2025

Platforms affected

N/A

Motivation and Context

fix workflows.

Description

Testing

  • Workflow ran
  • iOS test failed but not related this change (Not detected as iOS simulator)

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@kumo01GitHub kumo01GitHub changed the title Ci/ios workflows ci(ios): fix workflows Apr 24, 2025
@kumo01GitHub
Copy link
Contributor Author

kumo01GitHub commented Apr 24, 2025

If workflow should follow ordova-paramedic, I think that these change should be removed or wait until cordova-paramedic would be updated:

  • Add iOS18 -> Already exists.
  • use setup-xcode@v1

@erisu
Copy link
Member

erisu commented Apr 24, 2025

The last PR was forgotten and I just merged it in.
Can you rebase this PR with main branch?

@kumo01GitHub
Copy link
Contributor Author

@erisu
Thank you. I rebased.

@erisu
Copy link
Member

erisu commented Apr 24, 2025

Thank you,

Also, for your changes, could make sure that its based on the following default template? I don't think you are missing anything but could try and drop the file contents in to make sure.

https://github.com/apache/cordova-paramedic/blob/master/.github/workflows/ios.yml

For the most part, I think all your changes follows the default template, except for maxim-lobanov/setup-xcode.
We need to keep it pinned to the same commit ID that's used in Paramedic default template.

Why commit-hash ID:

The Apache Software Foundation is moving toward blocking tags like v1 and prefers commit hash IDs instead. Not all GitHub Actions have been updated to reflect this yet, and I was planning to look into it. This requirement, as I understand it, mainly applies to third-party actions — I believe GitHub’s core actions (e.g. actions/checkout) won’t be required to use commit hashes.

For Additional Information

Apache Cordova's base configurations always originate from Paramedic, so we try to keep them identical. If we're planning to make changes, Cordova usually updates Paramedic first to set the default template, and then we apply the updates across all plugins.

There are only a few exceptions where plugins have slight differences — for example, the File Transfer plugin, but they would be altered based on the default template.

@kumo01GitHub
Copy link
Contributor Author

kumo01GitHub commented Apr 24, 2025

@erisu
I got you. I also understood why don't use v1 tag now, so I removed this change:

  • use setup-xcode@v1

And also, I checked that there are no other differences compared with paramedic template.

@erisu
Copy link
Member

erisu commented Apr 26, 2025

I will merge this PR as is. The failing iOS tests are unrelated to this PR.

I believe the failing iOS tests are due to the location permission not being approved.

When running the tests manually, a permission dialog appears. If the permission is approved, the tests pass. If ignored, the tests time out, showing the same results we see in GitHub Actions.

I believe we will need to figure out a way to configure what permissions should be approved at the plugin's workflow level, and pass it to Paramedic which would perform the approval step. For example, we can approve the location permission using the following terminal command:

xcrun simctl privacy booted grant location io.cordova.hellocordova

We would need to run the above command after the app is installed on the simulator but before the app is launched.

This work is out of scope for this PR and would require further investigation, discussion, and possibly raising it on the dev mailing list.

@erisu erisu merged commit 882fbcc into apache:master Apr 26, 2025
11 of 15 checks passed
@kumo01GitHub kumo01GitHub deleted the ci/ios-workflows branch April 27, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants