-
Notifications
You must be signed in to change notification settings - Fork 662
ci(ios): fix workflows #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If workflow should follow ordova-paramedic, I think that these change should be removed or wait until cordova-paramedic would be updated:
|
|
The last PR was forgotten and I just merged it in. |
|
@erisu |
|
Thank you, Also, for your changes, could make sure that its based on the following default template? I don't think you are missing anything but could try and drop the file contents in to make sure. https://github.com/apache/cordova-paramedic/blob/master/.github/workflows/ios.yml For the most part, I think all your changes follows the default template, except for Why commit-hash ID: The Apache Software Foundation is moving toward blocking tags like For Additional InformationApache Cordova's base configurations always originate from Paramedic, so we try to keep them identical. If we're planning to make changes, Cordova usually updates Paramedic first to set the default template, and then we apply the updates across all plugins. There are only a few exceptions where plugins have slight differences — for example, the File Transfer plugin, but they would be altered based on the default template. |
|
@erisu
And also, I checked that there are no other differences compared with paramedic template. |
|
I will merge this PR as is. The failing iOS tests are unrelated to this PR. I believe the failing iOS tests are due to the location permission not being approved. When running the tests manually, a permission dialog appears. If the permission is approved, the tests pass. If ignored, the tests time out, showing the same results we see in GitHub Actions. I believe we will need to figure out a way to configure what permissions should be approved at the plugin's workflow level, and pass it to Paramedic which would perform the approval step. For example, we can approve the location permission using the following terminal command: xcrun simctl privacy booted grant location io.cordova.hellocordovaWe would need to run the above command after the app is installed on the simulator but before the app is launched. This work is out of scope for this PR and would require further investigation, discussion, and possibly raising it on the dev mailing list. |
Platforms affected
N/A
Motivation and Context
fix workflows.
Description
macos-12use setup-xcode@v1Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))