#113 (browser) - Properly detect new Edge Chromium version as Edge instead of Chrome

[mark-veenstra]

Platforms affected

browser

Motivation and Context

Allows the plugin to properly detect the new Edge browser based on Chromium.
#113

Description

The new Chromium based Edge browser exposed the following userAgent:

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.88 Safari/537.36 Edg/79.0.309.54

This change detects the browser as Edge instead of Chrome. And pulls the correct version.

Testing

On Edge and on Edge Chromium based execture the plugin and get the model and version

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

Closes #113

[mark-veenstra]

Any updates?

[domschmidt]

please review & merge asap =)

[timbru31]

Unfortunately, the change won't work.

[timbru31]

This won't work, as the offset might be set to -1 again and line 47 would return userAgent.substring(-1 + 4);