Skip to content

Comments

fix: handle permissions for getUserMedia#1895

Open
jcesarmobile wants to merge 2 commits intomasterfrom
getusermedia-perm
Open

fix: handle permissions for getUserMedia#1895
jcesarmobile wants to merge 2 commits intomasterfrom
getusermedia-perm

Conversation

@jcesarmobile
Copy link
Member

closes #1888

The code is based on Capacitor's implementation.

It uses newer ActivityResultCallback/ActivityResultLauncher instead of the old requestPermissions.

This could later on be extended to request geolocation permissions as at the moment it requires the Geolocation plugin to be installed.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.43%. Comparing base (6b17223) to head (7106112).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1895   +/-   ##
=======================================
  Coverage   61.43%   61.43%           
=======================================
  Files          24       24           
  Lines        4922     4922           
=======================================
  Hits         3024     3024           
  Misses       1898     1898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebView permission request breaks with no native permission granted

2 participants