Skip to content

Clear direct byte buffers#855

Merged
garydgregory merged 2 commits into
apache:masterfrom
garydgregory:fix/clear_direct_byte_buffers
May 31, 2026
Merged

Clear direct byte buffers#855
garydgregory merged 2 commits into
apache:masterfrom
garydgregory:fix/clear_direct_byte_buffers

Conversation

@garydgregory
Copy link
Copy Markdown
Member

@garydgregory garydgregory commented May 31, 2026

BufferedFileChannelInputStream now clears its direct memory byte buffer on close.

MemoryMappedFileInputStream now clears its direct memory byte buffer on close.

FileChannels.contentEquals(ReadableByteChannel, ReadableByteChannel, int) now clears its direct memory byte buffer on close.

BufferedFileChannelInputStream now clears its direct memory byte buffer on close.

MemoryMappedFileInputStream now clears its direct memory byte buffer on close.

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

on close.

MemoryMappedFileInputStream now clears its direct memory byte buffer on
close.

FileChannels.contentEquals(ReadableByteChannel, ReadableByteChannel,
int) now clears its direct memory byte buffer on close.

BufferedFileChannelInputStream now clears its direct memory byte buffer
on close.

MemoryMappedFileInputStream now clears its direct memory byte buffer on
close.
@garydgregory garydgregory merged commit d5eccce into apache:master May 31, 2026
21 checks passed
@garydgregory garydgregory deleted the fix/clear_direct_byte_buffers branch May 31, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant