KVM Host HA code improvements by sureshanaparti · Pull Request #13088 · apache/cloudstack

sureshanaparti · 2026-04-29T16:55:24Z

Description

This PR addresses the fix to not cancel VM HA items when Host HA is enabled & inspection in progress and improves the Host HA code (updates logs and some refactoring / cleanup).

When Host HA inspection in progress, the KVM investigor returns the Host Status as Up which cancels the VM HA items, don't cancel the VM HA items instead reschedule them to try again later.

This addresses #7543, #12922

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sureshanaparti · 2026-04-29T17:03:17Z

@blueorangutan package

codecov · 2026-04-29T17:03:56Z

Codecov Report

❌ Patch coverage is 11.11111% with 328 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.68%. Comparing base (ffebe8e) to head (646863f).
⚠️ Report is 9 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...ache/cloudstack/kvm/ha/KVMHostActivityChecker.java	0.00%	96 Missing ⚠️
...java/com/cloud/ha/HighAvailabilityManagerImpl.java	12.67%	60 Missing and 2 partials ⚠️
...n/java/org/apache/cloudstack/ha/HAManagerImpl.java	0.00%	36 Missing ⚠️
...om/cloud/hypervisor/kvm/resource/KVMHAMonitor.java	0.00%	29 Missing ⚠️
...vm/src/main/java/com/cloud/ha/KVMInvestigator.java	0.00%	16 Missing ⚠️
...oud/hypervisor/kvm/storage/LibvirtStoragePool.java	0.00%	16 Missing ⚠️
...java/org/apache/cloudstack/kvm/ha/KVMHAConfig.java	0.00%	10 Missing ⚠️
...oud/hypervisor/kvm/storage/LinstorStoragePool.java	0.00%	7 Missing ⚠️
...ud/hypervisor/kvm/storage/StorPoolStoragePool.java	0.00%	5 Missing ⚠️
...g/apache/cloudstack/ha/task/ActivityCheckTask.java	0.00%	5 Missing ⚠️
... and 23 more

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #13088   +/-   ##
=========================================
  Coverage     17.67%   17.68%           
- Complexity    15789    15793    +4     
=========================================
  Files          5922     5922           
  Lines        533094   533119   +25     
  Branches      65210    65201    -9     
=========================================
+ Hits          94246    94259   +13     
- Misses       428208   428216    +8     
- Partials      10640    10644    +4

Flag	Coverage Δ
uitests	`3.69% <ø> (ø)`
unittests	`18.75% <11.11%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2026-04-29T17:04:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-04-29T18:15:23Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17658

sureshanaparti · 2026-04-29T19:35:16Z

@blueorangutan test

blueorangutan · 2026-04-29T19:36:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

DaanHoogland

lgtm and good cleanup (needs testing though)

blueorangutan · 2026-04-30T10:33:08Z

[SF] Trillian test result (tid-15989)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50948 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13088-t15989-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

… progress, and some code improvements - When Host HA inspection in progress, the investigor returns the Host Status as Up which cancels the VM HA items - Don't cancel the VM HA items, instead reschedule them to try again later

sureshanaparti · 2026-05-06T08:25:51Z

@blueorangutan package

blueorangutan · 2026-05-06T08:28:05Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-06T09:25:19Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17729

…agent connection status to determine the Host HA inspection in progress or not, and some code improvements

sureshanaparti · 2026-05-06T15:00:15Z

@blueorangutan package

blueorangutan · 2026-05-06T15:06:05Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-06T16:07:33Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17741

sureshanaparti · 2026-05-06T16:15:05Z

@blueorangutan test

blueorangutan · 2026-05-06T16:16:04Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-05-07T05:58:49Z

[SF] Trillian test result (tid-16032)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 46549 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13088-t16032-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

sureshanaparti · 2026-05-07T20:00:27Z

@blueorangutan package

blueorangutan · 2026-05-07T20:02:05Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-07T21:35:03Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17764

sureshanaparti · 2026-05-07T21:37:10Z

@blueorangutan test

blueorangutan · 2026-05-07T21:38:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sureshanaparti · 2026-05-08T08:03:30Z

@blueorangutan package

blueorangutan · 2026-05-08T08:04:05Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-08T09:12:44Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17779

weizhouapache · 2026-05-08T09:52:05Z

@blueorangutan test

blueorangutan · 2026-05-08T09:54:06Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-05-08T12:20:47Z

[SF] Trillian test result (tid-16044)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50147 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13088-t16044-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

kiranchavala

LGTM

Tested manually with the following global setting value

Create a HA enabled offering
Deploy a vm with ha enabled offering
Confiugure OOBM on the kvm host with either ipmi or redfish
Enable host ha on the kvm host
Trigger kernel panic on the host

echo c > /proc/sysrq-trigger

Host Ha successfully gets triggered
VM HA also kicks in

Logs

[root@ref-trl-11669-k-Mol8-kiran-chavala-mgmt1 ~]# cat   /var/log/cloudstack/management/management-server.log.2026-05-06 |grep -i "logid:9b1252df"
2026-05-06 17:29:42,814 INFO  [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) Processing work HAWork[8-HA-7-Running-Investigating]
2026-05-06 17:29:42,816 DEBUG [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) RESTART with HA WORK
2026-05-06 17:29:42,819 DEBUG [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) Checking Host HA inspection is in progress or not for the host 1 from HAConfig, HA state is Fenced
2026-05-06 17:29:42,820 DEBUG [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) SimpleInvestigator unable to determine the state of the host.  Moving on.
2026-05-06 17:29:42,820 DEBUG [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) XenServerInvestigator unable to determine the state of the host.  Moving on.
2026-05-06 17:29:42,822 DEBUG [o.a.c.h.HAManagerImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) HA: Agent [Host {"id":1,"name":"ref-trl-11669-k-Mol8-kiran-chavala-kvm1","type":"Routing","uuid":"fe5f72ef-5285-4d8d-91f7-c7a951ff2279"}] is fenced.
2026-05-06 17:29:42,823 DEBUG [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) KVMInvestigator was able to determine host Host {"id":1,"name":"ref-trl-11669-k-Mol8-kiran-chavala-kvm1","type":"Routing","uuid":"fe5f72ef-5285-4d8d-91f7-c7a951ff2279"} is in Down
2026-05-06 17:29:42,823 INFO  [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) HA on VM instance {"id":7,"instanceName":"i-2-7-VM","state":"Running","type":"User","uuid":"eeacfde8-6019-477d-8551-952c4a2dc7cf"}
2026-05-06 17:29:42,825 DEBUG [c.c.a.m.ClusteredAgentManagerImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) Wait time setting on com.cloud.agent.api.CheckVirtualMachineCommand is 20 seconds
2026-05-06 17:29:42,827 DEBUG [c.c.h.CheckOnAgentInvestigator] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) Unable to reach the agent for VM instance {"id":7,"instanceName":"i-2-7-VM","state":"Running","type":"User","uuid":"eeacfde8-6019-477d-8551-952c4a2dc7cf"}: Resource [Host:1] is unreachable: Host 1: Host with specified id is not in the right state: Down
2026-05-06 17:29:42,827 INFO  [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) SimpleInvestigator could not find VM instance {"id":7,"instanceName":"i-2-7-VM","state":"Running","type":"User","uuid":"eeacfde8-6019-477d-8551-952c4a2dc7cf"}
2026-05-06 17:29:42,827 INFO  [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) XenServerInvestigator could not find VM instance {"id":7,"instanceName":"i-2-7-VM","state":"Running","type":"User","uuid":"eeacfde8-6019-477d-8551-952c4a2dc7cf"}
2026-05-06 17:29:42,829 DEBUG [o.a.c.h.HAManagerImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) HA: Host [Host {"id":1,"name":"ref-trl-11669-k-Mol8-kiran-chavala-kvm1","type":"Routing","uuid":"fe5f72ef-5285-4d8d-91f7-c7a951ff2279"}] is fenced.
2026-05-06 17:29:42,829 INFO  [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) KVMInvestigator found VM instance {"id":7,"instanceName":"i-2-7-VM","state":"Running","type":"User","uuid":"eeacfde8-6019-477d-8551-952c4a2dc7cf"} to be alive? false
2026-05-06 17:29:42,829 WARN  [o.a.c.f.j.AsyncJobExecutionContext] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) Job is executed without a context, setup psudo job for the executing thread
2026-05-06 17:29:42,843 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) Sync job-91 execution on object VmWorkJobQueue.7
2026-05-06 17:29:43,691 DEBUG [c.c.v.ClusteredVirtualMachineManagerImpl] (HA-Worker-4:[ctx-094abc4b, work-8, ctx-b87ca687]) (logid:9b1252df) start parameter value of enterHardwareSetup == null during processing of queued job
2026-05-06 17:29:43,698 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (HA-Worker-4:[ctx-094abc4b, work-8, ctx-b87ca687]) (logid:9b1252df) Sync job-92 execution on object VmWorkJobQueue.7
2026-05-06 17:29:48,376 INFO  [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) HA is now restarting VM instance {"id":7,"instanceName":"i-2-7-VM","state":"Running","type":"User","uuid":"eeacfde8-6019-477d-8551-952c4a2dc7cf"} on Host {"id":2,"name":"ref-trl-11669-k-Mol8-kiran-chavala-kvm2","type":"Routing","uuid":"c5bbfd66-800f-4634-ae73-46aa4d823868"}
2026-05-06 17:29:48,379 WARN  [c.c.a.AlertManagerImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) alertType=[8] dataCenterId=[1] podId=[1] clusterId=[null] message=[HA starting VM: t5 (i-2-7-VM)].
2026-05-06 17:29:48,390 WARN  [c.c.a.AlertManagerImpl] (HA-Worker-4:[ctx-094abc4b, work-8]) (logid:9b1252df) No recipients set in global setting 'alert.email.addresses', skipping sending alert with subject [HA starting VM: t5 (i-2-7-VM)] and content [HA starting VM: t5 (i-2-7-VM)].
2026-0

Host HA code improvements

a454e85

boring-cyborg Bot added component:api component:hyperv component:iscsi component:kvm component:primary-storage component:storage component:vmware labels Apr 29, 2026

Update simulator investigator

c3f6d76

boring-cyborg Bot added the component:simulator label Apr 29, 2026

sureshanaparti changed the title ~~Host HA code improvements~~ KVM Host HA code improvements Apr 29, 2026

DaanHoogland approved these changes Apr 30, 2026

View reviewed changes

DaanHoogland added the ready-for-testing label Apr 30, 2026

sureshanaparti marked this pull request as ready for review May 6, 2026 08:31

sureshanaparti added 2 commits May 6, 2026 15:24

code improvements

dc17cb7

Changes to consider Recovered/Available Host HA state along with the …

26035d4

…agent connection status to determine the Host HA inspection in progress or not, and some code improvements

simulator method fix

66e9b45

weizhouapache added this to the 4.22.1 milestone May 7, 2026

code improvements

6e3ae48

code improvements

646863f

kiranchavala approved these changes May 8, 2026

View reviewed changes

sureshanaparti added this to Apache CloudStack 4.22.1 May 8, 2026

github-project-automation Bot moved this to Todo in Apache CloudStack 4.22.1 May 8, 2026

sureshanaparti moved this from Todo to In Progress in Apache CloudStack 4.22.1 May 8, 2026

sureshanaparti linked an issue May 8, 2026 that may be closed by this pull request

KVM Host HA: host reaches Fenced but VMs remain Running on failed host and HA work is marked Done without restart #12922

Closed

sureshanaparti merged commit 4359198 into apache:4.22 May 8, 2026
24 of 26 checks passed

github-project-automation Bot moved this from In Progress to Done in Apache CloudStack 4.22.1 May 8, 2026

sureshanaparti deleted the host-ha-code-improvements branch May 8, 2026 14:20

Conversation

sureshanaparti commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Apr 29, 2026

Uh oh!

codecov Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Apr 29, 2026

Uh oh!

blueorangutan commented Apr 29, 2026

Uh oh!

sureshanaparti commented Apr 29, 2026

Uh oh!

blueorangutan commented Apr 29, 2026

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Apr 30, 2026

Uh oh!

sureshanaparti commented May 6, 2026

Uh oh!

blueorangutan commented May 6, 2026

Uh oh!

blueorangutan commented May 6, 2026

Uh oh!

sureshanaparti commented May 6, 2026

Uh oh!

blueorangutan commented May 6, 2026

Uh oh!

blueorangutan commented May 6, 2026

Uh oh!

sureshanaparti commented May 6, 2026

Uh oh!

blueorangutan commented May 6, 2026

Uh oh!

blueorangutan commented May 7, 2026

Uh oh!

sureshanaparti commented May 7, 2026

Uh oh!

blueorangutan commented May 7, 2026

Uh oh!

blueorangutan commented May 7, 2026

Uh oh!

sureshanaparti commented May 7, 2026

Uh oh!

blueorangutan commented May 7, 2026

Uh oh!

sureshanaparti commented May 8, 2026

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

weizhouapache commented May 8, 2026

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

sureshanaparti commented Apr 29, 2026 •

edited

Loading

codecov Bot commented Apr 29, 2026 •

edited

Loading