Add the procedure files for insert extensions and update guest os category #12482

sureshanaparti · 2026-01-21T07:50:14Z

Description

This PR adds the procedure files for insert extensions and update guestos category.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copilot

Pull request overview

This PR adds new SQL stored procedures for managing extensions and guest OS categories in the CloudStack database schema. The procedures provide reusable database operations for inserting extensions, updating guest OS categories, and managing related details.

Changes:

Added procedures for inserting extensions and their associated details/custom actions
Added procedures for updating and managing guest OS categories
All procedures include idempotency checks to prevent duplicate entries

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
cloud.update_new_and_delete_old_category_for_guest_os.sql	Adds procedure to migrate guest OS entries from one category to another and soft-delete the old category
cloud.update_category_for_guest_oses.sql	Adds procedure to update guest OS entries to a new category based on display name matching
cloud.insert_extension_if_not_exists.sql	Adds procedure to insert extension records if they don't already exist
cloud.insert_extension_detail_if_not_exists.sql	Adds procedure to insert extension detail records if they don't already exist
cloud.insert_extension_custom_action_if_not_exists.sql	Adds procedure to insert extension custom action records if they don't already exist
cloud.insert_extension_custom_action_details_if_not_exists.sql	Adds procedure to insert extension custom action detail records if they don't already exist
cloud.insert_category_if_not_exists.sql	Adds procedure to insert guest OS category records if they don't already exist

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...ources/META-INF/db/procedures/cloud.insert_extension_custom_action_details_if_not_exists.sql

...n/resources/META-INF/db/procedures/cloud.update_new_and_delete_old_category_for_guest_os.sql

...ma/src/main/resources/META-INF/db/procedures/cloud.insert_extension_detail_if_not_exists.sql

engine/schema/src/main/resources/META-INF/db/procedures/cloud.insert_category_if_not_exists.sql

...ma/src/main/resources/META-INF/db/procedures/cloud.insert_extension_detail_if_not_exists.sql

...main/resources/META-INF/db/procedures/cloud.insert_extension_custom_action_if_not_exists.sql

codecov · 2026-01-21T07:58:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.60%. Comparing base (1b2ae13) to head (bb914b1).
⚠️ Report is 3 commits behind head on 4.22.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12482      +/-   ##
============================================
- Coverage     17.60%   17.60%   -0.01%     
  Complexity    15618    15618              
============================================
  Files          5911     5911              
  Lines        530099   530126      +27     
  Branches      64776    64781       +5     
============================================
+ Hits          93313    93314       +1     
- Misses       426282   426309      +27     
+ Partials      10504    10503       -1

Flag	Coverage Δ
uitests	`3.60% <ø> (ø)`
unittests	`18.67% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti · 2026-01-21T08:09:14Z

@blueorangutan package

blueorangutan · 2026-01-21T08:10:34Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland

clgtm, though the co-pilot comments mostly make sense they are not vital.

blueorangutan · 2026-01-21T09:11:36Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 16458

sureshanaparti · 2026-01-21T09:16:12Z

@blueorangutan package

blueorangutan · 2026-01-21T09:18:35Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sureshanaparti · 2026-01-21T09:23:21Z

clgtm, though the co-pilot comments mostly make sense they are not vital.

@DaanHoogland these procedures (already tested / working ones) are from here - https://github.com/apache/cloudstack/blob/4.22/engine/schema/src/main/resources/META-INF/db/schema-42010to42100.sql. ignoring the null validation suggestion there.

blueorangutan · 2026-01-21T10:04:11Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16464

shwstppr

Not sure if we really need all these procedures but looks same as the original change.

minor comment on indentation

shwstppr · 2026-01-28T05:37:49Z

...ources/META-INF/db/procedures/cloud.insert_extension_custom_action_details_if_not_exists.sql

+BEGIN
+    DECLARE action_id BIGINT UNSIGNED
+;   SELECT `eca`.`id` INTO action_id FROM `cloud`.`extension_custom_action` `eca`
+                                                          JOIN `cloud`.`extension` `e` ON `e`.`id` = `eca`.`extension_id`


Indentation is bit off. Is that intentional?

ah, not intentional. I copied from upgrade schema file. let me check and fix that.

fixed indentation, thanks for pointing out @shwstppr

vishesh92

clgtm.
tested that procedure exists after the installation and works as expected.

…gory

sureshanaparti · 2026-01-28T10:31:39Z

@blueorangutan package

blueorangutan · 2026-01-28T10:32:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-28T11:39:07Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16587

...ma/src/main/resources/META-INF/db/procedures/cloud.insert_extension_detail_if_not_exists.sql

Co-authored-by: Vishesh <8760112+vishesh92@users.noreply.github.com>

vishesh92 · 2026-01-28T12:36:51Z

@blueorangutan package

blueorangutan · 2026-01-28T12:38:05Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-28T13:46:40Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16595

sureshanaparti mentioned this pull request Jan 21, 2026

[Upgrade 4.21 to 4.22] java.sql.SQLSyntaxErrorException: PROCEDURE cloud.INSERT_EXTENSION_IF_NOT_EXISTS does not exist #12460

Open

sureshanaparti requested review from DaanHoogland and Copilot January 21, 2026 07:51

sureshanaparti added this to the 4.22.1 milestone Jan 21, 2026

sureshanaparti added this to Apache CloudStack 4.22.1 Jan 21, 2026

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.1 Jan 21, 2026

sureshanaparti added the component:upgrade label Jan 21, 2026

Copilot started reviewing on behalf of sureshanaparti January 21, 2026 07:52 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

sureshanaparti requested review from harikrishna-patnala and shwstppr January 21, 2026 08:10

DaanHoogland approved these changes Jan 21, 2026

View reviewed changes

shwstppr approved these changes Jan 28, 2026

View reviewed changes

vishesh92 self-assigned this Jan 28, 2026

vishesh92 approved these changes Jan 28, 2026

View reviewed changes

sureshanaparti added 2 commits January 28, 2026 16:00

Add the procedure files for insert extensions and update guestos cate…

618db62

…gory

fixed indentation

9bcc164

sureshanaparti force-pushed the add-procedures-to-files branch from a8e765f to 9bcc164 Compare January 28, 2026 10:30

vishesh92 reviewed Jan 28, 2026

View reviewed changes

...ma/src/main/resources/META-INF/db/procedures/cloud.insert_extension_detail_if_not_exists.sql Outdated Show resolved Hide resolved

Apply suggestions from code review

bb914b1

Co-authored-by: Vishesh <8760112+vishesh92@users.noreply.github.com>

Add the procedure files for insert extensions and update guest os category #12482

Are you sure you want to change the base?

Add the procedure files for insert extensions and update guest os category #12482

Conversation

sureshanaparti commented Jan 21, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti commented Jan 21, 2026

Uh oh!

blueorangutan commented Jan 21, 2026

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jan 21, 2026

Uh oh!

sureshanaparti commented Jan 21, 2026

Uh oh!

blueorangutan commented Jan 21, 2026

Uh oh!

sureshanaparti commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Jan 21, 2026

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Jan 28, 2026

Uh oh!

blueorangutan commented Jan 28, 2026

Uh oh!

blueorangutan commented Jan 28, 2026

Uh oh!

Uh oh!

vishesh92 commented Jan 28, 2026

Uh oh!

blueorangutan commented Jan 28, 2026

Uh oh!

blueorangutan commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

codecov bot commented Jan 21, 2026 •

edited

Loading

sureshanaparti commented Jan 21, 2026 •

edited

Loading