Skip to content

Conversation

@Tonitzpp
Copy link
Contributor

Description

Currently, it is possible to check whether a range of public IPs is reserved for system VMs or not; however, this information can be hard to find since it’s located in a sub-menu with a name that doesn’t relate to the topic. Thus, this PR moves this information directly to the ranges listing in the Public tab under the Traffic types of a physical network.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

IP range before the changes: Captura de tela de 2025-12-30 09-48-15
IP range after the changes: Captura de tela de 2025-12-30 09-53-13

How Has This Been Tested?

I added two new IP ranges to a Public traffic type in a physical network, one being dedicated to system VMs, while the other was not. When the traffic type details was accessed, it was possible to validate that the dedicated range appeared as true in the Reserved system IP column, while the other one appeared as false.

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.85%. Comparing base (46cb805) to head (a34801d).
⚠️ Report is 135 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12461      +/-   ##
============================================
+ Coverage     17.60%   17.85%   +0.24%     
- Complexity    15668    15982     +314     
============================================
  Files          5915     5929      +14     
  Lines        529967   531045    +1078     
  Branches      64734    64913     +179     
============================================
+ Hits          93304    94794    +1490     
+ Misses       426195   425636     -559     
- Partials      10468    10615     +147     
Flag Coverage Δ
uitests 3.58% <ø> (+<0.01%) ⬆️
unittests 18.94% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12461 (QA-JID-849)

Copy link
Contributor

@Damans227 Damans227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the fix at https://qa.cloudstack.cloud/client/pr/12461/#/dashboard

Navigated to Infrastructure > Zones > Physical Network > Public traffic type and examined the IP Ranges table.

The new "Reserved system IP" column is now visible in the table and correctly displays "false" for non-reserved IP ranges (verified with range 192.168.1.10 - 192.168.1.199).

image

Copy link
Contributor

@Damans227 Damans227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward and clean. LGTM.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland merged commit 434e472 into apache:main Jan 28, 2026
25 of 27 checks passed
@DaanHoogland DaanHoogland added this to the 4.23.0 milestone Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants