-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Change to display if public IPs are reserved in the tab #12461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to display if public IPs are reserved in the tab #12461
Conversation
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12461 +/- ##
============================================
+ Coverage 17.60% 17.85% +0.24%
- Complexity 15668 15982 +314
============================================
Files 5915 5929 +14
Lines 529967 531045 +1078
Branches 64734 64913 +179
============================================
+ Hits 93304 94794 +1490
+ Misses 426195 425636 -559
- Partials 10468 10615 +147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
Damans227
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the fix at https://qa.cloudstack.cloud/client/pr/12461/#/dashboard
Navigated to Infrastructure > Zones > Physical Network > Public traffic type and examined the IP Ranges table.
The new "Reserved system IP" column is now visible in the table and correctly displays "false" for non-reserved IP ranges (verified with range 192.168.1.10 - 192.168.1.199).
Damans227
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward and clean. LGTM.
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Description
Currently, it is possible to check whether a range of public IPs is reserved for system VMs or not; however, this information can be hard to find since it’s located in a sub-menu with a name that doesn’t relate to the topic. Thus, this PR moves this information directly to the ranges listing in the
Publictab under the Traffic types of a physical network.Types of changes
Feature/Enhancement Scale
Screenshots (if appropriate):
IP range before the changes:
IP range after the changes:
How Has This Been Tested?
I added two new IP ranges to a
Publictraffic type in a physical network, one being dedicated to system VMs, while the other was not. When the traffic type details was accessed, it was possible to validate that the dedicated range appeared astruein theReserved system IPcolumn, while the other one appeared asfalse.