Fix host metrics on overprovisioning change

[vishesh92]

Description

Fixes #7591

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.76%. Comparing base (ef1aaa0) to head (e7d72fe).
⚠️ Report is 4 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/capacity/CapacityManagerImpl.java	0.00%	9 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #12403      +/-   ##
============================================
+ Coverage     16.23%   17.76%   +1.52%     
- Complexity    13381    15862    +2481     
============================================
  Files          5657     5923     +266     
  Lines        498947   530544   +31597     
  Branches      60555    64830    +4275     
============================================
+ Hits          81025    94262   +13237     
- Misses       408889   425736   +16847     
- Partials       9033    10546    +1513     

Flag	Coverage Δ
uitests	3.57% <ø> (-0.44%)	⬇️
unittests	18.85% <0.00%> (+1.75%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR fixes a bug where host CPU and memory usage metrics were incorrectly affected by overprovisioning factor changes. The issue caused metrics (Prometheus exporter's cloudstack_host_cpu_usage_mhz_total and API's listHosts response field cpuused) to report incorrect values when overprovisioning factors were modified.

Changes:

• Removed overprovisioning factor calculations from used CPU and memory metrics
• Removed overprovisioning factor calculations from reserved CPU and memory metrics

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[DaanHoogland]

@vishesh92 , should this be based off of 4.20?

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16331

[DaanHoogland]

clgtm