[CELEBORN-2262] Prepare S3 directory only once and cache s3 client for MultiPartUploader#3604
Open
eolivelli wants to merge 4 commits intoapache:mainfrom
Open
[CELEBORN-2262] Prepare S3 directory only once and cache s3 client for MultiPartUploader#3604eolivelli wants to merge 4 commits intoapache:mainfrom
eolivelli wants to merge 4 commits intoapache:mainfrom
Conversation
… MultiPartUploader (apache#4) - Create only one S3 client for all MultiPartUploaders - Create S3 worker directory only once and not for every slot - Because on S3 AWS creating connections is slow (due to credentials handshaking and TLS handshaking) - Because "mkdirs" in S3 AWS is very slow (and it needs several S3 calls) No No Manual testing on real S3 AWS
|
Thanks for your contribution @eolivelli, I will take a look at this PR before tomorrow and add comments if needed. |
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala
Outdated
Show resolved
Hide resolved
...loader/multipart-uploader-s3/src/main/java/org/apache/celeborn/S3MultipartUploadHandler.java
Outdated
Show resolved
Hide resolved
...loader/multipart-uploader-s3/src/main/java/org/apache/celeborn/S3MultipartUploadHandler.java
Show resolved
Hide resolved
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala
Outdated
Show resolved
Hide resolved
SteNicholas
changed the title
SteNicholas
reviewed
Feb 19, 2026
...in/java/org/apache/celeborn/server/common/service/mpu/MultipartUploadHandlerSharedState.java
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Feb 19, 2026
Member
There was a problem hiding this comment.
@eolivelli, thanks for improvement of S3MultipartUploadHandler. The changes generally look good. Could you provide the testing report of the performance with this improvement?
Contributor
Author
I added some flamegraphs in the PR description. |
SteNicholas
reviewed
Feb 19, 2026
...loader/multipart-uploader-s3/src/main/java/org/apache/celeborn/S3MultipartUploadHandler.java
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Feb 19, 2026
...loader/multipart-uploader-s3/src/main/java/org/apache/celeborn/S3MultipartUploadHandler.java
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Feb 19, 2026
...loader/multipart-uploader-s3/src/main/java/org/apache/celeborn/S3MultipartUploadHandler.java
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Feb 19, 2026
...loader/multipart-uploader-s3/src/main/java/org/apache/celeborn/S3MultipartUploadHandler.java
Show resolved
Hide resolved
SteNicholas
reviewed
Feb 19, 2026
...in/java/org/apache/celeborn/server/common/service/mpu/MultipartUploadHandlerSharedState.java
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Feb 19, 2026
SteNicholas
requested changes
Feb 19, 2026
SteNicholas
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Sample CPU flamegraph about the need of Connection pooling:
Sample CPU flamegraph about the need of pooling the client due to AssumeRoleWithWebIdentity
Does this PR resolve a correctness bug?
No
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual testing.
There is one end-to-end integration test with S3 that exercise this code