[CELEBORN-2235][CIP-14] Adapt Java end's serialization to CppWriterClient #3561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:client
kind:infra
module:common
module:cpp
module:worker
labels
Contributor
Author
|
@SteNicholas @RexXiong @FMX @afterincomparableyum Could you kindly help review this PR? Thanks a lot. Note that this PR adds modification to Java end, which has to be carefully reviewed. Any suggestion is welcome, thanks a lot. |
|
I will take a look over the next couple of days @HolyLow, thank you for letting me know |
SteNicholas
approved these changes
Dec 16, 2025
RexXiong
reviewed
Dec 31, 2025
| serdeVersion: SerdeVersion) | ||
| extends RequestLocationCallContext with Logging { | ||
| val endedMapIds = new util.HashSet[Integer]() | ||
| val endedMapIds = new util.ArrayList[Integer]() |
Contributor
There was a problem hiding this comment.
Why change HashSet to ArrayList? Is there a specific reason or benefit for doing so?
Contributor
Author
There was a problem hiding this comment.
ArrayList takes less overhead than HashSet, so here we change to use ArrayList. Besides, it is more complex to convert between HashSet and ProtoBuf's List data structure.
RexXiong
approved these changes
Jan 5, 2026
Contributor
|
Thanks, merge to main(v0.7.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adapts Java end's serialization to CppWriterClient, including RegisterShuffle/Response, Revive/Response, MapperEnd/Response. Joint test for cpp-write java-read procedure is included as well.
Why are the changes needed?
Support writing to Celeborn server with CppWriterClient.
Does this PR resolve a correctness bug?
No.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Compilation and integration tests.