Ensure schema created before 2.1 without tableId in folder name can b…#4661
Open
Jollyplum wants to merge 1 commit intoapache:cassandra-5.0from
Open
Ensure schema created before 2.1 without tableId in folder name can b…#4661Jollyplum wants to merge 1 commit intoapache:cassandra-5.0from
Jollyplum wants to merge 1 commit intoapache:cassandra-5.0from
Conversation
Jollyplum
force-pushed
the
mbyrd/CASSANDRA-21173/cassandra-5.0
branch
2 times, most recently
from
a3516dd to
83bfe22
Compare
…e loaded in SnapshotLoader Best effort attempt to get tableId from CFS, fallback to null which still allows snapshot to be loaded End result is that nodetool clearsnapshot and listsnapshot function for such snapshots on restart patch by Matt Byrd; reviewed by for CASSANDRA-21173
Jollyplum
force-pushed
the
mbyrd/CASSANDRA-21173/cassandra-5.0
branch
from
83bfe22 to
3ae9aa4
Compare
smiklosovic
reviewed
Mar 20, 2026
| else | ||
| { | ||
| logger.warn("Snapshot directory without tableId found (pre-2.1 format) " + | ||
| "Keyspace not initliazed or missing schema unable to initialize tableId default to null {}", snapshotDir); |
Contributor
There was a problem hiding this comment.
Could you add a dot (".") between these two sentences? I am maybe too pedantic but this reads better
Snapshot directory without table id found (pre-2.1 format), keyspace is not initialized or there is a schema missing, defaulting to null, snapshot dir: {}
You have also a typo in "initliazed".
smiklosovic
reviewed
Mar 20, 2026
|
|
||
| if (tableId == null) | ||
| { | ||
| logger.warn("Snapshot directory without tableId found (pre-2.1 format) " + |
Contributor
There was a problem hiding this comment.
Snapshot directory without table id found (pre-2.1 format), unable to resolve table id from column family, defaulting to null, snapshot dir: {}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e loaded in SnapshotLoader
We now store tableId in manifest.json so that snapshots from tables without tableId in folder name loaded by SnapshotLoader have this information.
End result is that nodetool clearsnapshot and listsnapshot function for such snapshots
patch by Matt Byrd; reviewed by for CASSANDRA-21173