Skip to content

Conversation

@bbotella
Copy link
Contributor

@bbotella bbotella changed the title CASSSIDECAR-163 Integrate delta-coverage-plugin plugin CASSSIDECAR-163: Integrate delta-coverage-plugin plugin Nov 21, 2024
Copy link
Contributor

@frankgh frankgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks good to me

@@ -1,5 +1,6 @@
1.0.0
-----
* Integrate delta-coverage-plugin plugin (CASSSIDECAR-163)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to add this change here because it's not anything that touches code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it then :-)

build.gradle Outdated
id("org.nosphere.apache.rat") version "0.8.0"

id 'jacoco'
id("io.github.surpsg.delta-coverage") version "2.4.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to upgrade gradle for the project :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! I'll create a Jira for it ☺️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yifan-c
Copy link
Contributor

yifan-c commented Nov 22, 2024

Can you add the delta coverage execution as part of the CircleCI build? Since unit and integration test are split across multiple pipelines, (unit first, then integration). I think you need store the coverage data and combine them once integration test finishes.

@bbotella bbotella requested a review from frankgh December 16, 2024 22:50
@bbotella bbotella force-pushed the CASSSIDECAR-163-diff-coverage branch from f181767 to cca767b Compare December 20, 2024 19:05
@bbotella
Copy link
Contributor Author

@skoppu22
Copy link
Contributor

Happy to see this, coverage checked for open source repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants