-
Notifications
You must be signed in to change notification settings - Fork 52
CASSSIDECAR-163: Integrate delta-coverage-plugin plugin #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
frankgh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 looks good to me
| @@ -1,5 +1,6 @@ | |||
| 1.0.0 | |||
| ----- | |||
| * Integrate delta-coverage-plugin plugin (CASSSIDECAR-163) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to add this change here because it's not anything that touches code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove it then :-)
build.gradle
Outdated
| id("org.nosphere.apache.rat") version "0.8.0" | ||
|
|
||
| id 'jacoco' | ||
| id("io.github.surpsg.delta-coverage") version "2.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to upgrade gradle for the project :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed! I'll create a Jira for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Can you add the delta coverage execution as part of the CircleCI build? Since unit and integration test are split across multiple pipelines, (unit first, then integration). I think you need store the coverage data and combine them once integration test finishes. |
https://issues.apache.org/jira/browse/CASSSIDECAR-163 Adds changes.txt Adds changes.txt Readds missing change
f181767 to
cca767b
Compare
|
@yifan-c Added the aggregation for cicle. Working example here |
|
Happy to see this, coverage checked for open source repo |
https://issues.apache.org/jira/browse/CASSSIDECAR-163