Skip to content

chore: agent quality expectations #23579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
squakez wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

chore: agent quality expectations #23579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,16 @@ When creating a PR, **always identify and request reviews** from the most releva
- All code must pass formatting checks (`mvn formatter:format impsort:sort`) before pushing.
- All generated files must be regenerated and committed (CI checks for uncommitted changes).

### Quality Expectations

- Even if static analysis is not executed during contribution validation, contributions should avoid introducing new static code analysis issues such as:
- code smells
- maintainability regressions
- CWE (Common Weakness Enumeration)
- Top OWASP vulnerabilities and security flows
- Avoid usage of deprecated code
- Changes should aim to preserve or improve overall code quality.

### Asynchronous Testing: Use Awaitility Instead of Thread.sleep

Do **NOT** use `Thread.sleep()` in test code. It leads to flaky, slow, and non-deterministic tests.
Expand Down
Loading