Skip to content

updated the get_catalog.sh to check weather maven is present or not.#6642

Open
anandyadav3559 wants to merge 3 commits into
apache:mainfrom
anandyadav3559:main
Open

updated the get_catalog.sh to check weather maven is present or not.#6642
anandyadav3559 wants to merge 3 commits into
apache:mainfrom
anandyadav3559:main

Conversation

@anandyadav3559
Copy link
Copy Markdown
Contributor

if maven not installed prompt user to install it. during make build I came around this issue and system default promopt is not very understandable.

…if not prompt user to isntall it. during make build I came around this issue and system default promopt is not very understandable
squakez
squakez previously approved these changes May 20, 2026
Copy link
Copy Markdown
Contributor Author

@anandyadav3559 anandyadav3559 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: #6631

Motivation: Right now we leverage the presence of the make target to perform installation of the older operator version during the upgrade E2E test. This forces the test to pull the entire GitHub project locally just to run the Makefile. We can instead install directly from the tag via a Kustomize procedure, which is faster and cleaner.

Modifications:

Removed the logic in e2e/install/upgrade/upgrade_test.go that creates a temporary directory, executes git clone, checks out the target tag, and runs make install-k8s-global.
Replaced it with a temporary kustomization.yaml that dynamically applies the generated test namespace alongside the remote GitHub repository base (github.com/apache/camel-k/install/overlays/kubernetes/descoped?ref=v).
Executed installation using kubectl apply -k --server-side.
Testing Verification:

✅ make fmt and make lint completed successfully with no issues.
⚠️ Note on Local testing with kind: While running the go test -v ./e2e/install/upgrade -tags=integration suite on a local kind cluster, the test initially timed out because the IntegrationPlatform resource failed to reach the Ready state. The operator logs showed: registry address not available, you need to set one. Because Camel K requires a container registry to push/pull integration images, and a local kind cluster does not provide one automatically, a local Docker registry had to be explicitly created and connected to the kind cluster for the upgrade tests to proceed and pass correctly.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't mix commits and stick to the scope of this PR. If you want, feel free to open a separated PR to address any other fix. For the upgrade test, mind that this is already fixed by another running PR, so, no need to work on it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright.

@squakez squakez dismissed their stale review May 22, 2026 09:38

The approved code was modified. Please, change it accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants