Skip to content

[CALCITE-7408] URL_ENCODE/URL_DECODE is unparsed incorrectly for ClickHouseSqlDialect #4784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuzifu666 merged 1 commit into from
Feb 10, 2026
+28 −0
Merged

[CALCITE-7408] URL_ENCODE/URL_DECODE is unparsed incorrectly for ClickHouseSqlDialect #4784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions core/src/main/java/org/apache/calcite/sql/dialect/ClickHouseSqlDialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import org.apache.calcite.sql.SqlTimeLiteral;
import org.apache.calcite.sql.SqlTimestampLiteral;
import org.apache.calcite.sql.SqlWriter;
import org.apache.calcite.sql.fun.SqlLibraryOperators;
import org.apache.calcite.sql.fun.SqlStdOperatorTable;
import org.apache.calcite.sql.parser.SqlParserPos;
import org.apache.calcite.sql.type.SqlTypeName;
Expand Down Expand Up @@ -228,6 +229,20 @@ private static SqlDataTypeSpec createSqlDataTypeSpecByName(String typeAlias,
return;
}

// refer to https://clickhouse.com/docs/sql-reference/functions/url-functions#encodeURLComponent
if (call.getOperator() == SqlLibraryOperators.URL_ENCODE) {
RelToSqlConverterUtil.specialOperatorByName("encodeURLComponent")
.unparse(writer, call, 0, 0);
return;
}

// refer to https://clickhouse.com/docs/sql-reference/functions/url-functions#decodeURLComponent
if (call.getOperator() == SqlLibraryOperators.URL_DECODE) {
RelToSqlConverterUtil.specialOperatorByName("decodeURLComponent")
.unparse(writer, call, 0, 0);
return;
}

switch (call.getKind()) {
case MAP_VALUE_CONSTRUCTOR:
writer.print(call.getOperator().getName().toLowerCase(Locale.ROOT));
Expand Down
13 changes: 13 additions & 0 deletions core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3701,6 +3701,19 @@ private SqlDialect nonOrdinalDialect() {
sql(query2).withSpark().ok(expected2);
}

/** Test case for
* <a href="https://issues.apache.org/jira/browse/CALCITE-7408">[CALCITE-7408]
* URL_ENCODE/URL_DECODE is unparsed incorrectly for ClickHouseSqlDialect</a>. */
@Test void testUrlencodeAndUrldecode() {
final String query = "SELECT URL_ENCODE(\"product_name\") from \"product\"";
final String expected = "SELECT encodeURLComponent(`product_name`)\nFROM `foodmart`.`product`";
sql(query).withLibrary(SqlLibrary.SPARK).withClickHouse().ok(expected);

final String query1 = "SELECT URL_DECODE(\"product_name\") from \"product\"";
final String expected1 = "SELECT decodeURLComponent(`product_name`)\nFROM `foodmart`.`product`";
sql(query1).withLibrary(SqlLibrary.SPARK).withClickHouse().ok(expected1);
}

@Test void testInstrFunction4Operands() {
final String query = "SELECT INSTR('ABC', 'A', 1, 1) from \"product\"";
final String expectedBQ = "SELECT INSTR('ABC', 'A', 1, 1)\n"
Expand Down
Loading