Support multi source source provenance info #2098
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-zivkovic
force-pushed
the
JZ/multi-source-provenance
branch
3 times, most recently
from
2064cf3 to
2b0267c
Compare
joshua-zivkovic
force-pushed
the
JZ/multi-source-provenance
branch
from
2b0267c to
84d65c5
Compare
joshua-zivkovic
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow,
gtristan and
juergbi
as code owners
juergbi
reviewed
Dec 12, 2025
joshua-zivkovic
force-pushed
the
JZ/multi-source-provenance
branch
from
84d65c5 to
835981f
Compare
Contributor
|
Do plugins need access to the actual |
Author
|
Yup, taking in to account #2095 (comment), there's no need to expose SourceProvenance to achieve this. |
This allows multi-source source plugins to provide this information per source rather than as a singular top level. This is done by adding a `provenance_node` parameter to `create_source_info()` that when specified overrides the use of the source's top level source provenance info. Co-authored-by: Jürg Billeter <j@bitron.ch>
juergbi
force-pushed
the
JZ/multi-source-provenance
branch
from
835981f to
bbc05ba
Compare
Contributor
|
I've updated this branch as per my previous comment, but this still requires a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2073
This PR provides a way for multi-source plugins to provide source provenance info in their own way instead of only the top level source source info being used.
This is done by exposing the optional
source_provenance_attrsargument tocreate_source_info()which when used overrides the usage of the default provenance for a source. Any plugin that needs to parse provenance in it's own way can then supply it's results using this. This has been trialled with thecargo2source plugin in https://gitlab.com/BuildStream/buildstream-plugins-community/-/merge_requests/408.