_elementsources: cache intermediate combined sources (in-memory) #2094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tracking an element that has multiple sources that depend on previous sources, buildstream stages all previous sources each time, and since they aren't cached because we only cache sources that don't depend on previous sources or combined elements this ends up staging things from original sources again and again. This change keeps the a digest of the intermediate staged sources in memory, and speeds up these cases a lot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tracking an element that has multiple sources that depend on previous sources, buildstream stages all previous sources each time, and since they aren't cached because we only cache sources that don't depend on previous sources or combined elements this ends up staging things from original sources again and again.
This change keeps the a digest of the intermediate staged sources in memory, and speeds up these cases a lot