Support artifact remote options in bst artifact show
#2088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for ensuring that the shallow artifacts have been downloaded
from the remotes, without requiring heavy duty `bst artifact pull`, and
is particularly useful with the advent of `%{artifact-cas-digest}` being
available in `bst show` output.
This updates the CLI to support the new arguments which we missed
adding previously, and adds the glue code in Stream() object to
load the pipeline with the artifact remote related arguments.
…a dir This just follows the new, improved policy to not share data files across test cases, leading to the huge crazy shared mess that is found in tests/frontend/project, where any change here for a given test risks affecting many adjacent tests.
Added tests to cover --artifact-remote and --ignore-project-artifact-remotes. This also improves overall coverage of test_artifact_show_available_remotely to cover all three methods of setting the remotes (project, user config, and now CLI options), plus test this by providing the element name and the artifact name separately (except for when the remote is specified by the project, because project.conf is intentionally ignored when loading artifact names).
gtristan
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
juergbi
as code owners
gtristan
force-pushed
the
tristan/artifact-show-remote
branch
from
cc9b7a3 to
ccb6f55
Compare
Contributor
Author
|
No reviews in a while... trivial and uncontroversial change (consistent CLI options) which also improves test coverage... lets merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command was missed when applying the
--artifact-remoteand--ignore-project-artifact-remotesoptions uniformly to all relevant commands.