Skip to content

skip return true if the end of the stream is reached #3242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenBright merged 2 commits into from
Mar 16, 2026
+10 −6
Merged

skip return true if the end of the stream is reached #3242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b0a204
return true if the end of the stream is reached
Mar 11, 2026
e34a05d
update the comment with protocolbuffers/protobuf@ab25c3e
Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/butil/iobuf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1849,10 +1849,14 @@ void IOBufAsZeroCopyInputStream::BackUp(int count) {
}
}

// Skips a number of bytes. Returns false if the end of the stream is
// reached or some input error occurred. In the end-of-stream case, the
// stream is advanced to the end of the stream (so ByteCount() will return
// the total size of the stream).
// Skips `count` number of bytes.
// Returns true on success, or false if some input error occurred, or `count`
// exceeds the end of the stream. This function may skip up to `count - 1`
// bytes in case of failure.
//
// Preconditions:
// * `count` is non-negative.
//
bool IOBufAsZeroCopyInputStream::Skip(int count) {
const IOBuf::BlockRef* cur_ref = _buf->_pref_at(_ref_index);
while (cur_ref) {
Expand All @@ -1867,7 +1871,7 @@ bool IOBufAsZeroCopyInputStream::Skip(int count) {
_byte_count += left_bytes;
cur_ref = _buf->_pref_at(++_ref_index);
}
return false;
return (0 == count);
}

int64_t IOBufAsZeroCopyInputStream::ByteCount() const {
Expand Down Expand Up @@ -2102,4 +2106,4 @@ bool IOBufBytesIterator::forward_one_block(const void** data, size_t* size) {

void* fast_memcpy(void *__restrict dest, const void *__restrict src, size_t n) {
return butil::iobuf::cp(dest, src, n);
} // namespace butil
} // namespace butil
Loading