Fix BigQuery Storage Write API stream count for bounded writes#38776
Fix BigQuery Storage Write API stream count for bounded writes#38776Akshatsharma2205 wants to merge 3 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the functionality of the BigQuery Storage Write API by allowing the number of write streams to be configured for bounded (batch) writes, in addition to the existing support for unbounded (streaming) writes. The changes ensure that stream count configurations are applied consistently across different pipeline types while maintaining existing constraints on triggering frequency and auto-sharding for streaming data. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables the use of fixed stream counts (numStreams) for both batch (bounded) and streaming (unbounded) pipelines in the BigQuery Storage Write API, updating the Java and Python SDKs as well as the documentation. The review feedback suggests validating that numStreams is non-negative to prevent silent configuration errors, and simplifying the conditional check once validation is in place.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
The failing/cancelled checks appear unrelated to this PR. I checked the visible annotations and did not see failures mentioning the changed BigQuery files or docs. Several failures are in Python ML/anomaly/RAG tests or CI timeouts. Could the failed/cancelled checks be rerun when convenient? |
|
thanks for looking into this bug |
|
Assigning reviewers: R: @jrmccluskey for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request enables using fixed stream counts (numStreams) for both batch and streaming pipelines in the BigQuery Storage Write API. It moves the numStreams configuration logic outside of the unbounded-only check, adds validation to ensure numStreams is non-negative, and updates the corresponding documentation and Python SDK docstrings. Feedback on the changes suggests adding a validation check to ensure numStreams can only be set to 0 if autoSharding is enabled, preventing configurations where 0 streams are silently ignored.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| if (numStreams != null) { | ||
| checkArgument( | ||
| numStreams >= 0, | ||
| invalidConfigMessage + "numStreams must be non-negative, but was: %s", | ||
| numStreams); | ||
| } |
There was a problem hiding this comment.
If numStreams is explicitly set to 0 but autoSharding is not enabled (or is false), the configuration is accepted but numStreams is silently ignored in BigQueryStorageWriteApiSchemaTransformProvider (since it only applies numStreams if it is > 0). To prevent confusing behavior where a user configures 0 streams expecting that to be applied, we should validate that numStreams can only be 0 if autoSharding is enabled.
if (numStreams != null) {
checkArgument(
numStreams >= 0,
invalidConfigMessage + "numStreams must be non-negative, but was: %s",
numStreams);
if (numStreams == 0) {
checkArgument(
autoSharding != null && autoSharding,
invalidConfigMessage + "numStreams can only be 0 if autoSharding is enabled.");
}
}There was a problem hiding this comment.
Thanks for the suggestion i looked into the existing BigQueryIO semantics and i think this validation would be broader than the scope of this PR.
numStorageWriteApiStreams currently uses 0 as the default/unset sentinel in BigQueryIO, and withNumStorageWriteApiStreams(0) is documented as valid behavior: for streaming it lets the runner determine sharding, and for batch it avoids inserting a redistribute and keeps the existing pipeline parallelism.
Because autoSharding is only applicable to unbounded input, requiring numStreams == 0 to also have autoSharding == true would reject or complicate valid/default batch behavior and would be a behavior change beyond this PR’s narrow goal of allowing positive fixed stream counts for bounded Storage Write API writes.
Given that Id prefer not to add this validation unless a reviewer wants to intentionally change the accepted schema transform semantics for explicit numStreams: 0.
2 participants
Summary
Fixes #38770
Validation
git diff --checksuccessfully../gradlew :sdks:java:io:google-cloud-platform:compileJavalocally, but the build did not reach Java compilation because this was prepared from a sparse checkout missing Beam build plugin infrastructure.Key Gradle error:
Java compilation did not start.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.