Handle empty batches in Python worker counters#38748
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a runtime error occurring in the Python worker's operation counters when encountering empty batches. By explicitly checking for a batch length of zero, the system avoids division by zero during byte size estimation and ensures that counters remain stable when no elements are present. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request prevents a potential division-by-zero error in opcounters.py by returning early when processing empty batches, and adds a corresponding unit test. The reviewer suggests using math.nan instead of float('nan') in the new test for better performance and idiomatic Python.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Handles empty batched values in
OperationCounters.update_from_batchwithout estimating a per-element byte size when the batch converter reports length zero.This keeps empty batches from raising
ZeroDivisionErrorin the worker counter path. It also leaves the mean byte counter unchanged because there are no elements to average.Addresses #38742.
Testing
From
sdks/python:python -m pytest -q apache_beam/runners/worker/opcounters_test.py::OperationCountersTest::test_update_empty_batchpython -m pytest -q apache_beam/runners/worker/opcounters_test.pypython -m pytest -q apache_beam/typehints/batch_test.pygit diff --checkThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.