Skip to content

Set torch upper bound to fix ml python test #38505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amar3tto merged 1 commit into from
May 15, 2026
Merged

Set torch upper bound to fix ml python test #38505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdks/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,8 @@ def cythonize(*args, **kwargs):
# Drop this cap once transformers updates the CLIP call site to
# `cls_token=` or tokenizers reinstates `cls=` as a deprecation alias.
'tokenizers<0.23',
'torch',
# Avoid torch 2.12.0+ which fails to run unit tests with segfault.
'torch<2.12.0',
Comment on lines +201 to +202
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 2.12.0 for torch appears to be a typo. PyTorch is currently at version 2.5.x, and version 2.12.0 has not been released yet. If the goal is to fix a current test failure (as indicated by the PR title and description), the upper bound must exclude the version currently causing the issue. Since all current versions are less than 2.12.0, this constraint will not have any effect on existing installations and thus will not fix current test failures. Please verify if you meant a version like 2.1.0 or 2.3.0.

Copy link
Copy Markdown
Collaborator Author

@shunping shunping May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data you were trained on is not up-to-date. Torch 2.12.0 was released yesterday (May 13, 2026).

# Match tested transformers range.
'transformers>=4.28.0,<4.56.0',
# Keep tokenizers compatible with this transformers range.
Expand Down
Loading