Skip to content

Make sure session creation happens before starting agent #38477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
damccorm wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −11
Draft

Make sure session creation happens before starting agent #38477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions sdks/python/apache_beam/ml/inference/agent_development_kit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,17 +229,6 @@ def run_inference(
for element in batch:
session_id: str = inference_args.get("session_id", str(uuid.uuid4()))

# Ensure a session exists for this invocation
try:
model.session_service.create_session(
app_name=self._app_name,
user_id=user_id,
session_id=session_id,
)
except sessions.SessionExistsError:
# It's okay if the session already exists for shared session IDs.
pass

# Wrap plain strings in a Content object
if isinstance(element, str):
# pyrefly: ignore[bad-instantiation]
Expand Down Expand Up @@ -288,6 +277,16 @@ async def _invoke_agent(
The text of the agent's final response, or ``None`` if the agent
produced no final text response.
"""
# Ensure a session exists for this invocation
try:
await model.session_service.create_session(
app_name=self._app_name,
user_id=user_id,
session_id=session_id,
)
except sessions.SessionExistsError:
# It's okay if the session already exists for shared session IDs.
pass
async for event in runner.run_async(
user_id=user_id,
session_id=session_id,
Expand Down
Loading