-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Bump urllib3 to patched release in Python container requirements #38467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -222,7 +222,7 @@ typing_extensions==4.15.0 | |
| tzdata==2025.3 | ||
| tzlocal==5.3.1 | ||
| uritemplate==4.2.0 | ||
| urllib3==2.6.3 | ||
| urllib3==2.7.0 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This security update is inconsistent across the container requirement files. The following files are missing from this PR: sdks/python/container/py312/base_image_requirements.txt (Standard Python 3.12) and sdks/python/container/ml/py313/gpu_image_requirements.txt (ML Python 3.13 GPU). Please ensure all relevant containers are updated to maintain a consistent security posture. |
||
| virtualenv-clone==0.5.7 | ||
| websockets==16.0 | ||
| wheel==0.46.3 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -184,7 +184,7 @@ tqdm==4.67.3 | |
| typing-inspection==0.4.2 | ||
| typing_extensions==4.15.0 | ||
| tzdata==2025.3 | ||
| urllib3==2.6.3 | ||
| urllib3==2.7.0 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| virtualenv-clone==0.5.7 | ||
| websockets==16.0 | ||
| wheel==0.46.3 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version "2.7.0" for urllib3 does not appear to exist on PyPI (the current latest stable version is 2.3.0). Pinning to a non-existent version will cause container build failures. Please verify the intended version; if this is meant to address recent security advisories, you likely intended to use 2.2.2, 2.2.3, or 2.3.0. Additionally, the previous version 2.6.3 also appears to be non-existent on PyPI, suggesting a systematic typo in these requirement files that should be corrected across all instances.