Skip to content

Fix Portable PreCommit on 3.14 #38033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrmccluskey merged 2 commits into from
Apr 1, 2026
Merged

Fix Portable PreCommit on 3.14 #38033

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aef2834
Fix Portable PreCommit on 3.14
jrmccluskey Apr 1, 2026
9b7e855
linting
jrmccluskey Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sdks/python/apache_beam/runners/portability/portable_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,15 @@ def add_runner_options(parser):
try:
# no default values - we don't want runner options
# added unless they were specified by the user
add_arg_args = {'action': 'store', 'help': option.description}
add_arg_args = {'action': 'store'}
if option.description is not None:
# Prevent bare %'s in help strings in 3.14+
add_arg_args['help'] = option.description.replace("%", "%%")
if option.type == beam_job_api_pb2.PipelineOptionType.BOOLEAN:
add_arg_args['action'] = 'store_true' \
if option.default_value != 'true' else 'store_false'
elif option.type == beam_job_api_pb2.PipelineOptionType.INTEGER:
add_arg_args['type'] = int
add_arg_args['type'] = int # type: ignore
elif option.type == beam_job_api_pb2.PipelineOptionType.ARRAY:
add_arg_args['action'] = 'append'
parser.add_argument("--%s" % option.name, **add_arg_args)
Expand Down
Loading