Skip to content

[yaml] Remove test_ReadFromBigQuery_ExternalJavaProvider_0 deselection#37986

Open
derrickaw wants to merge 2 commits intoapache:masterfrom
derrickaw:remove_deselect_test_ReadFromBigQuery_ExternalJavaProvider_0
Open

[yaml] Remove test_ReadFromBigQuery_ExternalJavaProvider_0 deselection#37986
derrickaw wants to merge 2 commits intoapache:masterfrom
derrickaw:remove_deselect_test_ReadFromBigQuery_ExternalJavaProvider_0

Conversation

@derrickaw
Copy link
Copy Markdown
Collaborator

@derrickaw derrickaw commented Mar 27, 2026

Follow-on PR from #37787 (comment) to remove the test deselection.

Fix: #30950

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cleans up the YAML integration test configuration by re-enabling a previously skipped test case. This change ensures better test coverage for BigQuery external Java provider functionality within the Python SDK.

Highlights

  • Test Deselection Removal: Removed the explicit deselection of the 'test_ReadFromBigQuery_ExternalJavaProvider_0' test case from the YAML integration test suite.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@derrickaw
Copy link
Copy Markdown
Collaborator Author

Run Python PreCommit 3.13

@derrickaw
Copy link
Copy Markdown
Collaborator Author

Run PythonDocker PreCommit 3.11

@derrickaw
Copy link
Copy Markdown
Collaborator Author

Run Python_Integration PreCommit 3.10

@derrickaw
Copy link
Copy Markdown
Collaborator Author

Run Python_ML PreCommit 3.10

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @shunping for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@derrickaw
Copy link
Copy Markdown
Collaborator Author

Hi @shunping or @damccorm, please retry that last test failure. It should pass. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Failing Test]: beam_PreCommit_Yaml_Xlang_Direct fails with with external bigquery write

1 participant